test: Add bin/test helper to invoke specs with mise#2983
Draft
sl0thentr0py wants to merge 1 commit into
Draft
Conversation
sl0thentr0py
changed the title
sl0thentr0py
force-pushed
the
neel/mise-test
branch
2 times, most recently
from
d98f2a3 to
9cb3f25
Compare
* `./bin/test -l`: list all cells across gems * `./bin/test --gem <gem>`: scope by gem, picks latest cell automatically if not supplied * `./bin/test --cell <cell>`: run a cell's specs under its mise ruby * `./bin/test --cell <cell> -- <spec args>`: forward args to rspec * `./bin/test --cell <cell> --rake`: run `bundle exec rake` like CI * per gem `./bin/test` wrappers that pass through to top level command * rename old rails `bin/test` -> `bin/test_old` * extract shared cell/mise machinery into `bin/lib/matrix.rb` (used by relock and test)
sl0thentr0py
force-pushed
the
neel/mise-test
branch
from
9cb3f25 to
a8c079f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a8c079f. Configure here.
| base = File.basename(parts[gi + 1], ".gemfile") | ||
|
|
||
| cell = discover_cells([gem]).find { |c| c.base == base } | ||
| abort "No cell '#{base}' in #{gem}/test-matrix.json. `bin/test -l` to list." unless cell |
There was a problem hiding this comment.
Duplicate wrapper paths drop matrix rows
Medium Severity
discover_cells deduplicates by wrapper, and --cell resolves a row only by base, so two test-matrix.json entries that share the same gemfile path but differ in options.rubyopt collapse to one cell. A --cell run for that path always applies the surviving row’s RUBYOPT, so the other CI job cannot be mirrored locally.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a8c079f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./bin/test -l: list all cells across gems./bin/test --gem <gem>: scope by gem, picks latest cell automatically if not supplied./bin/test --cell <cell>: run a cell's specs under its mise ruby./bin/test --cell <cell> -- <spec args>: forward args to rspec./bin/test --cell <cell> --rake: runbundle exec rakelike CIbin/lib/matrix.rb(used by relock and test)./bin/testwrappers that pass through to top level commandbin/test->bin/test_oldIssues