Skip to content

chore(reqwest): Record envelope losses in the Reqwest transport#1174

Open
szokeasaurusrex wants to merge 4 commits into
szokeasaurusrex/transport-report-recorderfrom
szokeasaurusrex/reqwest-losses
Open

chore(reqwest): Record envelope losses in the Reqwest transport#1174
szokeasaurusrex wants to merge 4 commits into
szokeasaurusrex/transport-report-recorderfrom
szokeasaurusrex/reqwest-losses

Conversation

@szokeasaurusrex

@szokeasaurusrex szokeasaurusrex commented Jun 17, 2026

Copy link
Copy Markdown
Member

Record lost envelopes in the reqwest transport. Also, add necessary loss reason enum variants.

Closes #1151
Closes RUST-226

@linear-code

linear-code Bot commented Jun 17, 2026

Copy link
Copy Markdown

RUST-226

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review June 17, 2026 17:24
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner June 17, 2026 17:24
Comment thread sentry-core/src/client/client_reports/recorder.rs
Comment thread sentry/src/transports/reqwest.rs Outdated

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from 1924d0f to d30ba16 Compare June 18, 2026 09:12
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from de80482 to 5e862da Compare June 18, 2026 09:12
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from d30ba16 to f04a352 Compare June 18, 2026 09:56
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 7906b9f to b629b0b Compare June 18, 2026 10:01
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from c2736b7 to 9e2510b Compare June 18, 2026 11:15
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from b629b0b to a530eb8 Compare June 18, 2026 13:16
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 9e2510b to 6cce3c1 Compare June 18, 2026 13:16
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from a530eb8 to 870bb6a Compare June 18, 2026 15:05
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 6cce3c1 to 8f54fdc Compare June 18, 2026 15:05
Comment thread sentry/src/transports/reqwest.rs Outdated
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 870bb6a to c7eecf6 Compare June 19, 2026 08:46
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from 1a8ff61 to 31469a9 Compare June 19, 2026 08:54
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from c7eecf6 to 9870e72 Compare June 19, 2026 08:54

@lcian lcian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from 9c4fe2c to 044bcda Compare June 19, 2026 09:45
cursor[bot]

This comment was marked as low quality.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 19e68bf to e82ade7 Compare June 19, 2026 12:08
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 044bcda to 5a39025 Compare June 19, 2026 12:08
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from e82ade7 to 1bcf0fd Compare June 19, 2026 16:05
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 5a39025 to 4bed875 Compare June 19, 2026 16:05
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 4bed875 to 7b23f11 Compare June 19, 2026 16:33
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 1bcf0fd to 651a1f3 Compare June 19, 2026 16:33
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from 7b23f11 to fdfd1f2 Compare June 21, 2026 16:36
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 651a1f3 to d45e8b8 Compare June 21, 2026 16:36
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from fdfd1f2 to b4061c2 Compare June 21, 2026 16:45
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from d45e8b8 to 12fe08a Compare June 21, 2026 16:45
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from 546b283 to e1b2e92 Compare June 21, 2026 18:28
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from 35165bd to b94ee40 Compare June 22, 2026 08:12
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch 2 times, most recently from 95481a4 to de4ac19 Compare June 22, 2026 11:20
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from b94ee40 to c90f232 Compare June 22, 2026 11:20
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from de4ac19 to f24e1e2 Compare June 22, 2026 15:54
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from c90f232 to e96d2c8 Compare June 22, 2026 15:54
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transport-report-recorder branch from e96d2c8 to fbe6662 Compare June 22, 2026 16:02
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/reqwest-losses branch from f24e1e2 to 7d5982b Compare June 22, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants