chore(curl): Record envelope losses in the Curl transport#1175
Open
szokeasaurusrex wants to merge 3 commits into
Open
chore(curl): Record envelope losses in the Curl transport#1175szokeasaurusrex wants to merge 3 commits into
szokeasaurusrex wants to merge 3 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
01e1dfc to
a400549
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
9e2510b to
6cce3c1
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
a400549 to
30b705d
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
6cce3c1 to
8f54fdc
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
2 times, most recently
from
d0fb9ec to
bd8072f
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
8f54fdc to
1a8ff61
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
bd8072f to
28f9398
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
2 times, most recently
from
31469a9 to
9c4fe2c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
28f9398 to
1d70a92
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
1d70a92 to
d566a6d
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
9c4fe2c to
044bcda
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
044bcda to
5a39025
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
d566a6d to
0d1f9c7
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
5a39025 to
4bed875
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
0d1f9c7 to
78d07ac
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
4bed875 to
7b23f11
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
78d07ac to
c5ba012
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
7b23f11 to
fdfd1f2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
c5ba012 to
de93acf
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
fdfd1f2 to
b4061c2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
de93acf to
c80c467
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
b4061c2 to
546b283
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
c80c467 to
5c62ea2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
546b283 to
e1b2e92
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
5c62ea2 to
398ca7c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
e1b2e92 to
95481a4
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
398ca7c to
a1f576a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
95481a4 to
de4ac19
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
a1f576a to
b58b512
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
de4ac19 to
f24e1e2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
b58b512 to
db5340b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db5340b. Configure here.
Record lost envelopes in the `curl` transport after the transport thread accepts them for sending. Curl execution failures are recorded as `network_error`; response-code lookup failures and non-`429` HTTP `4xx`/`5xx` responses are recorded as `send_error`. Keep existing rate-limit handling for `429` responses and the existing payload-too-large debug message for `413` responses. Closes [#1152](#1152) Closes [RUST-227](https://linear.app/getsentry/issue/RUST-227)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/reqwest-losses
branch
from
f24e1e2 to
7d5982b
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
db5340b to
547b8b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record lost envelopes in the
curltransport after the transport thread accepts them for sending. Curl execution failures are recorded asnetwork_error; response-code lookup failures and non-429HTTP4xx/5xxresponses are recorded assend_error.Keep existing rate-limit handling for
429responses and the existing payload-too-large debug message for413responses.Closes #1152
Closes RUST-227