chore(transport): Record std thread client report losses#1184
Open
szokeasaurusrex wants to merge 2 commits into
Open
chore(transport): Record std thread client report losses#1184szokeasaurusrex wants to merge 2 commits into
szokeasaurusrex wants to merge 2 commits into
Conversation
szokeasaurusrex
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 11324da. Configure here.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
3309c81 to
d48565f
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
11324da to
614c2e1
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
d48565f to
ca00003
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
614c2e1 to
bdff5cb
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
ca00003 to
e94b7e4
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
2 times, most recently
from
db28b96 to
96a15e5
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
e94b7e4 to
5b42ae7
Compare
Record envelopes dropped before the curl and ureq HTTP transports see them. The std transport thread now reports queue overflow, disconnected worker, and rate-limit drops through the client report recorder. Shutdown losses remain unreported because shutdown ends the opportunity to send another envelope carrying the aggregated client report. Fixes [#1149](#1149) Fixes [RUST-224](https://linear.app/getsentry/issue/RUST-224)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
5b42ae7 to
7e008a3
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
96a15e5 to
11f9014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record envelopes dropped before the curl and ureq HTTP transports see them. The std transport thread now reports queue overflow, disconnected worker, and rate-limit drops through the client report recorder.
Shutdown losses remain unreported because shutdown ends the opportunity to send another envelope carrying the aggregated client report.
Fixes #1149
Fixes RUST-224