fix(grpc): Increase max message size to 10MB#658
Merged
Conversation
The default gRPC max message size is 4MB. Tasks with payloads larger than this fail to be pushed to workers and get stuck in an infinite retry loop, causing the pending_activation_max_lag metric to flap. Broker side: Add grpc_max_message_size config (default 10MB) and use it when creating the WorkerServiceClient. Worker side: Add TASKBROKER_GRPC_MAX_MESSAGE_SIZE env var (default 10MB) and apply it to the gRPC server options. ref INC-2209 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
untitaker
force-pushed
the
fix-grpc-max-message-size
branch
from
993fb3a to
9ec3631
Compare
enochtangg
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiles sometimes take 7 MB, and a lot of our default kafka max message sizes are 10 MB. So I think 10 MB is a tolerable default.
Summary
grpc_max_message_sizeconfig option, use it when creating WorkerServiceClientTASKBROKER_GRPC_MAX_MESSAGE_SIZEenv var, apply to gRPC server optionsTest plan
cargo test)ref INC-2209
🤖 Generated with Claude Code