feat: Add default metrics tags to Sentry errors#659
Open
untitaker wants to merge 1 commit into
Open
Conversation
Apply the same default tags used for metrics (pool name, latency_tier) to Sentry errors, making it easier to filter and correlate errors with specific taskbroker instances. Uses configure_scope on the main thread and propagates the hub to spawned tasks via a custom spawn helper. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
| F: Future + Send + 'static, | ||
| F::Output: Send + 'static, | ||
| { | ||
| tokio::spawn(future.bind_hub(Hub::new_from_top(Hub::main()))) |
Member
There was a problem hiding this comment.
The compiler will probably inline all of this because it's so simple, but what if this was a macro?
Member
Author
There was a problem hiding this comment.
do you want this to be a macro in order for it to inline better? not sure I understand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taskbroker::tokio::spawnhelper that propagates the main Sentry hub to spawned tasks, ensuring tags are available across all threadsTest plan
🤖 Generated with Claude Code