test(evals): Add search agent evals for regex log search - #1405
Open
JoshuaKGoldberg wants to merge 5 commits into
Open
JoshuaKGoldberg wants to merge 5 commits into
JoshuaKGoldberg wants to merge 5 commits into
Conversation
Covers log searches that need key://pattern// regex, plus wildcard searches where regex isn't the better choice. The regex cases fail until the search agent's prompt teaches the syntax. Refs LOGS-1013
JoshuaKGoldberg
marked this pull request as ready for review
October 5, 2026 15:54
JoshuaKGoldberg
added this pull request to stack #1411
October 5, 2026 15:58
…ex cases Adds evals for (?i) patterns, UUIDs within the 64-character limit, prefix and either-or searches that should stay wildcards, and spans or errors searches that must not get a regex. Refs LOGS-1013 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regex matchers now reject over-long, lookaround, backreference, and over-escaped patterns, the non-logs cases must keep the user's text, and the plain-text guards no longer copy prompt examples. Refs LOGS-1013 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The regex check now also rejects possessive quantifiers, atomic groups, and escapes RE2 refuses, and the ignoring-case case accepts [0-9] as well as \d. Refs LOGS-1013 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… file
The possessive check no longer trips on character classes or \p{...}+,
more escapes RE2 refuses are rejected, and the file is biome-formatted.
Refs LOGS-1013
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JoshuaKGoldberg
had a problem deploying
to
Actions
October 5, 2026 20:13 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
search_eventsagent evals for log searches that needkey://pattern//regex, plus wildcard searches where regex isn't the better choice. The regex cases are expected to fail until the agent's prompt learns the syntax. I'm adding that in other PRs.Closes LOGS-1013.