Skip to content

Adopt Oxc lint and format tooling for MCP and root - #1419

Open
BYK wants to merge 2 commits into
fix/cli-skill-versionfrom
chore/oxlint-oxfmt
Open

BYK wants to merge 2 commits into
fix/cli-skill-versionfrom
chore/oxlint-oxfmt

Conversation

@BYK

@BYK BYK commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Run Oxlint and Oxfmt for MCP and root files, preserving CLI Biome and its custom Grit rules until they have equivalents.
  • Preserve staged-file isolation and accessibility checks; update generation, catalog, editor recommendations and contributor guidance.
  • Fix the five diagnostics exposed by Oxlint without changing behavior.

Stacked on #1415 because the current main branch has generated CLI skill-version drift that otherwise fails workspace CI. The PR diff contains only this tooling change.

Validation

  • Frozen pnpm install, root typecheck (after generating the ignored CLI API schema), root lint, docs check, generated-file check, focused MCP logging/CLI parsing tests, and 28 root script tests passed.
  • Full workspace test run reached 10,256 passing CLI tests but hit the existing 15-second timeout in the large ZIP test under load; its isolated rerun passed 15/15.

Keep the CLI's Biome rules until their custom Grit checks have equivalents. Run Oxfmt and Oxlint for the remaining workspaces, and preserve accessibility linting and staged-file isolation.

Co-Authored-By: GPT-6 Sol <agent@openai.com>

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .oxlintrc.json
@@ -0,0 +1,26 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["jsx-a11y"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oxlint plugins replace default set

High Severity

The plugins array lists only jsx-a11y. Oxlint treats that field as a replacement, so the default eslint, typescript, unicorn, and oxc plugins never load. categories.correctness then applies only to accessibility rules, and workspace lint no longer reports the correctness issues this migration is meant to catch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8671ccc. Configure here.

@github-actions github-actions Bot added the risk: low PR risk score: low label Oct 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d39c63b. Configure here.

Comment thread .vscode/extensions.json
@@ -1,4 +1,4 @@
{
"recommendations": ["biomejs.biome"],
"recommendations": ["oxc.oxc-vscode", "biomejs.biome"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editor still formats with Biome

Low Severity

Root VS Code settings still set Biome as the default formatter and on-save fixer after biome.json and the root @biomejs/biome dependency were removed. Format-on-save for MCP and root files will fail or apply Biome defaults instead of Oxfmt, fighting the new pre-commit and CI tooling.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d39c63b. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant