Skip to content

chore(formatting): undo shared formatter and keep structuredcontent - #1420

Open
shayna-ch wants to merge 9 commits into
mainfrom
shayna-ch/structuredcontent
Open

shayna-ch wants to merge 9 commits into
mainfrom
shayna-ch/structuredcontent

Conversation

@shayna-ch

@shayna-ch shayna-ch commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

removes everything related to the sentry shared formatter, no real behavioral change since the flag was turned off in the Sentry side so the shared formatter wasn't used. get_issue_details still returns structuredContent, now built from the MCP's own data.

deleted:

  • The ?llmFormat=json / ?llmFormat=markdown params on the event and autofix requests.
  • The formatted field on the event and autofix schemas.
  • usesSharedFormatterBody and wrapSeerContent, and the code that used them in get_issue_details, analyze_issue_with_seer and formatIssueOutput.

structuredContent:

  • event.body is now the MCP's own markdown for the event (formatEventOutput), not a parsed formatter payload. Transactions get the structured path too, with their performance trace in the body.
  • New event.message and responseNotes fields, so the structured result carries everything the markdown output shows. The markdown output and the structured payload build their notes with the same function.
  • Will only be on for users opted in to experimental mode. Outside experimental mode it will fallback to the og markdown

@shayna-ch

Copy link
Copy Markdown
Member Author

bugbot run

@shayna-ch shayna-ch changed the title undo shared formatter and keep structuredcontent chore(mcp): undo shared formatter and keep structuredcontent Oct 5, 2026
@shayna-ch shayna-ch changed the title chore(mcp): undo shared formatter and keep structuredcontent chore(formatting): undo shared formatter and keep structuredcontent Oct 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a9ba625. Configure here.

@shayna-ch
shayna-ch marked this pull request as ready for review October 5, 2026 22:30
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 5, 2026
mr-danya pushed a commit to mr-danya/sentry-mcp that referenced this pull request Oct 6, 2026
…#1420)

This PR fixes an issue where `sentry event view` would fail with a
`ResolutionError` when an issue short ID (e.g.,
`PRODUCTION-RCP-API-A9R`) was passed as the second positional argument
(e.g., `sentry event view <org>/<project> PRODUCTION-RCP-API-A9R`).

The root cause was that `parsePositionalArgs` in
`packages/cli/src/commands/event/view.ts` correctly checked
`looksLikeIssueShortId(first)` for the first argument but lacked a
corresponding check for `looksLikeIssueShortId(second)`.

The fix adds this missing check. Now, when an issue short ID is detected
as the second argument, `parsePositionalArgs` returns `{ eventId:
LATEST_EVENT_SENTINEL, targetArg: first, issueShortId: second }`,
allowing the command to correctly resolve the latest event for that
issue, preventing the misleading "is not a valid ID" error.

Fixes
[CLI-1EJ](https://sentry.sentry.io/issues/7437967683/?seerDrawer=true)

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: jared-outpost[bot] <jared-outpost[bot]@users.noreply.github.com>
mr-danya pushed a commit to mr-danya/sentry-mcp that referenced this pull request Oct 6, 2026
…#1420)

This PR fixes an issue where `sentry event view` would fail with a
`ResolutionError` when an issue short ID (e.g.,
`PRODUCTION-RCP-API-A9R`) was passed as the second positional argument
(e.g., `sentry event view <org>/<project> PRODUCTION-RCP-API-A9R`).

The root cause was that `parsePositionalArgs` in
`packages/cli/src/commands/event/view.ts` correctly checked
`looksLikeIssueShortId(first)` for the first argument but lacked a
corresponding check for `looksLikeIssueShortId(second)`.

The fix adds this missing check. Now, when an issue short ID is detected
as the second argument, `parsePositionalArgs` returns `{ eventId:
LATEST_EVENT_SENTINEL, targetArg: first, issueShortId: second }`,
allowing the command to correctly resolve the latest event for that
issue, preventing the misleading "is not a valid ID" error.

Fixes
[CLI-1EJ](https://sentry.sentry.io/issues/7437967683/?seerDrawer=true)

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: jared-outpost[bot] <jared-outpost[bot]@users.noreply.github.com>
mr-danya pushed a commit to mr-danya/sentry-mcp that referenced this pull request Oct 6, 2026
…#1420)

This PR fixes an issue where `sentry event view` would fail with a
`ResolutionError` when an issue short ID (e.g.,
`PRODUCTION-RCP-API-A9R`) was passed as the second positional argument
(e.g., `sentry event view <org>/<project> PRODUCTION-RCP-API-A9R`).

The root cause was that `parsePositionalArgs` in
`packages/cli/src/commands/event/view.ts` correctly checked
`looksLikeIssueShortId(first)` for the first argument but lacked a
corresponding check for `looksLikeIssueShortId(second)`.

The fix adds this missing check. Now, when an issue short ID is detected
as the second argument, `parsePositionalArgs` returns `{ eventId:
LATEST_EVENT_SENTINEL, targetArg: first, issueShortId: second }`,
allowing the command to correctly resolve the latest event for that
issue, preventing the misleading "is not a valid ID" error.

Fixes
[CLI-1EJ](https://sentry.sentry.io/issues/7437967683/?seerDrawer=true)

---------

Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Co-authored-by: jared-outpost[bot] <jared-outpost[bot]@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Actions — a3e42e88 Deployed Oct 5, 2026 by shayna-ch via eval #1237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant