Skip to content

fix(a11y): Row Detail missing aria-expanded attribute for accessibility - #2656

Merged
ghiscoding merged 1 commit into
masterfrom
bugfix/a11y-row-detail
Jul 21, 2026
Merged

fix(a11y): Row Detail missing aria-expanded attribute for accessibility#2656
ghiscoding merged 1 commit into
masterfrom
bugfix/a11y-row-detail

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

Two a11y gaps in the Row Detail plugin that match the pattern already established in Tree Data and Grouping:

  1. No aria-expanded on the toggle icon in detailSelectionFormatter
  2. No keyboard handler — Tree Data and Grouping both subscribe onKeyDown with Space (toggle), ArrowRight (expand), ArrowLeft (collapse) + editor-lock guard

@ghiscoding ghiscoding changed the title fix(a11y): add aria-expanded to Row Detail fix(a11y): Row Detail missing aria-expanded attribute for accessibility Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (4dff5d6) to head (6cb5ba8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25330    25345   +15     
  Branches     8954     8960    +6     
=======================================
+ Hits        25330    25345   +15     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 21, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2656

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2656

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2656

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2656

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2656

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2656

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2656

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2656

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2656

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2656

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2656

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2656

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2656

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2656

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2656

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2656

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2656

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2656

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2656

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2656

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2656

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2656

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2656

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2656

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2656

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2656

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2656

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2656

commit: 6cb5ba8

@ghiscoding
ghiscoding merged commit 2eb9242 into master Jul 21, 2026
15 checks passed
@ghiscoding
ghiscoding deleted the bugfix/a11y-row-detail branch July 21, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant