Add Gerrit forge adapter#119
Open
abhinavgautam01 wants to merge 2 commits into
Open
Conversation
|
+1 on this feature, fills the single gap that I have for the cli tool, will run a qa on it against my gerrit and provide feedback. |
andrew
requested changes
Jun 25, 2026
andrew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, the adapter is well structured and follows the existing gitea/gitlab shape closely. Tests pass locally and pr checkout will work for Gerrit changes for free since #117 already handles refs/-prefixed head refs.
A few things to address before merging, see inline. The main ones are the Code-Review label type, the hardcoded abandon/restore messages, and the gerrit-review.googlesource.com default which doesn't actually work with the auth scheme implemented here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds initial Gerrit support as a forge adapter.
This maps Gerrit projects, branches, tags, files, and changes into the existing forge interfaces where they fit cleanly. Unsupported Gerrit concepts explicitly return
ErrNotSupported.Closes #12.
What works
gerritforge type and detection via/config/server/versionTests
go test ./...git diff --check