Use ComputedInput for configuration file input#4045
Draft
mbg wants to merge 6 commits into
Draft
Conversation
ComputedInput for other applicable inputsComputedInput for configuration file input
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Generalizes computed input handling so config-file values and sources can be reported in telemetry.
Changes:
- Extracts reusable computed-input resolution.
- Tracks config-file values and sources in status reports.
- Adds non-empty repository-property validation.
Show a summary per file
| File | Description |
|---|---|
src/config/inputs.ts |
Generalizes computed-input resolution. |
src/config/file.ts |
Returns computed config-file input metadata. |
src/config/file.test.ts |
Updates config-file input tests. |
src/feature-flags/properties.ts |
Adds non-empty string validation. |
src/init-action.ts |
Propagates config-file input metadata. |
src/status-report.ts |
Reports the resolved config-file value. |
lib/entry-points.js |
Generated output; excluded from review. |
Review details
Files excluded by content exclusion policy (1)
- lib/entry-points.js
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Medium
| [K in RepositoryPropertyName]: PropertyInfo<K>; | ||
| } = { | ||
| [RepositoryPropertyName.CONFIG_FILE]: stringProperty, | ||
| [RepositoryPropertyName.CONFIG_FILE]: nonEmptyStringProperty, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies
getConfigFileInputto:ComputedInputvalue that we can report in telemetry, rather than just the computed value itself.getComputedInputfunction extracted fromgetToolsInput.A secondary change is the introduction of a
nonEmptyStringPropertyso that we can make this explicit inrepositoryPropertyParsersrather than dealing with empty strings everywhere downstream.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist