C++: Proper indirection in all QL models#21908
Draft
MathiasVP wants to merge 3 commits into
Draft
Conversation
MathiasVP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is step 1 in a series of PRs I plan to get merged which will eventually result in being able to merge the enormous 1 line change in #21622.
This PR just adds a bunch of indirections to our QL models. We currently get all of these "for free" because of the automating lifting of a
n1 -> n2model step to*n1 -> *n2here, but I plan on removing this model step in a subsequent PR since this is causing conflations (details on this will follow in another PR).Commit-by-commit review recommended. The first commit generalizes a bunch of dataflow/taint-tracking models to multiple indirections, and the next commit accepts the single test regression which is fixed by adding a missing model in the last commit.