C#: Remove the RawUrl sanitizer.#22180
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an incorrect RawUrl sanitizer model to restore open-redirect detection.
Changes:
- Removes the
RawUrlURL-redirection barrier. - Updates the CWE-601 regression test and expected alert.
- Adds a change note.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/lib/ext/System.Web.model.yml |
Removes the incorrect barrier model. |
csharp/ql/test/query-tests/Security Features/CWE-601/UrlRedirect/UrlRedirect.cs |
Marks RawUrl redirection as unsafe. |
csharp/ql/test/query-tests/Security Features/CWE-601/UrlRedirect/UrlRedirect.expected |
Records the restored alert. |
csharp/ql/src/change-notes/2026-07-13-CWE-601.md |
Documents the analysis change. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
Author
|
DCA looks good. One new result on |
owen-mc
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22174