C#: Use static constructor as enclosing callable for static member initializers.#22186
Draft
michaelnebel wants to merge 5 commits into
Draft
C#: Use static constructor as enclosing callable for static member initializers.#22186michaelnebel wants to merge 5 commits into
michaelnebel wants to merge 5 commits into
Conversation
… member initialization. Note that a class can only have ONE static constructor (so it will be unique).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query
cs/useless-assignment-to-localproduces some false positives for static members.That is, the query incorrectly reports
xas being a useless assignment inThe root cause of the problem is that the static member initializers don't have an enclosing callable (which affects the SSA logic and this bubbles up into the results of
cs/useless-assignment-to-localquery). In this PR we fix the problem by using the static constructor as the enclosing callable for the control flow elements/expressions of static member inititializers. For instance fields, there is a dedicated synthetic "object initializer" method (as there can exist multiple instance constructors). However, there is exactly one static constructor, so we can use that as the enclosing callable.Notes on DCA.
cs/useless-assignment-to-local. There appears to be two genuine alert removals. I only checked the alert removal in non-generated code and that appears to be a false positive removal (local variable declaration with subsequent use in a static member initialization - similar to the example provided above).cs/dereferenced-value-may-be-null: New alerts, which look good (method calls without null-checks on static members that are assigned the result of a cast).cs/coupled-types: New alerts. The query uses the enclosing callable for finding candidate types of variables accesses. I have no reason to doubt that these are not sound with respect to the query logic.cs/local-not-disposed: New alerts. I checked one, which looks sound. An IDisposable appears to be used as a part of initializing a static field. The query also relies on enclosing callable as a part of its logic.cs/virtual-call-in-constructor. New Alerts. These are false positives, but that is due to a query bug as we shouldn't considernameof(VirtualMethod)a virtual call - this is perfectly safe in constructors as well. Will open an issue for this.