Repository navigation
C++: Add support for more builtin operations - #22832
Merged
Merged
Conversation
jketema
added
the
depends on internal PR
jketema
force-pushed
the
jketema/builtin
branch
from
October 15, 2026 14:04
b4d5078 to
18c604b
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new expression test query silently omits member-access expressions because it assumes zero-based child indices.
2 open findings
What changed in this PR
Extends CodeQL’s C++ expression models to support seven additional compiler builtins.
Changes:
- Adds schema kinds and QL classes for type traits and spaceship-comparison builtins.
- Adds fixtures and expression-result checks.
- Provides schema migration support and a change note.
| File | Description |
|---|---|
cpp/ql/test/library-tests/builtins/type_traits/gcc.cpp |
Tests structural-type detection. |
cpp/ql/test/library-tests/builtins/type_traits/expr.expected |
Updates type-trait expectations. |
cpp/ql/test/library-tests/builtins/type_traits/clang.cpp |
Tests virtual bases and implicit lifetimes. |
cpp/ql/test/library-tests/builtins/builtins/spaceship.cpp |
Tests spaceship-related builtins. |
cpp/ql/test/library-tests/builtins/builtins/expr.ql |
Checks expression children and values. |
cpp/ql/test/library-tests/builtins/builtins/expr.expected |
Records expression expectations. |
cpp/ql/test/library-tests/builtins/builtins/builtins.expected |
Adds builtin classification expectations. |
cpp/ql/lib/upgrades/6aec212e408fad907b19368a3376a4d9837783d2/upgrade.properties |
Declares upgrade compatibility. |
cpp/ql/lib/upgrades/6aec212e408fad907b19368a3376a4d9837783d2/old.dbscheme |
Preserves the previous schema. |
cpp/ql/lib/semmlecode.cpp.dbscheme |
Adds seven builtin expression kinds. |
cpp/ql/lib/semmle/code/cpp/exprs/BuiltInOperations.qll |
Exposes new builtin QL classes. |
cpp/ql/lib/change-notes/2026-10-16-builtins.md |
Documents added support. |
cpp/downgrades/293904928d857b61a44dc0ff34c89c9eccb8a90a/upgrade.properties |
Configures partial downgrade behavior. |
cpp/downgrades/293904928d857b61a44dc0ff34c89c9eccb8a90a/semmlecode.cpp.dbscheme |
Defines the downgrade target schema. |
cpp/downgrades/293904928d857b61a44dc0ff34c89c9eccb8a90a/exprs.ql |
Maps unsupported kinds to error expressions. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.