Skip to content

fix(nodejs): Map suppressResumeEvent to disableResume on the wire #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MRayermannMSFT merged 3 commits into from
Jun 1, 2026
+4 −3
Merged

fix(nodejs): Map suppressResumeEvent to disableResume on the wire #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3641197
fix(nodejs): Map suppressResumeEvent to disableResume on the wire
willglas Jun 1, 2026
83d1c26
fix(dotnet): Map SuppressResumeEvent to disableResume on the wire
willglas Jun 1, 2026
395decd
test: Add gitHubToken to suspend E2E test server
willglas Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2385,7 +2385,7 @@ internal record ResumeSessionRequest(
bool? EnableHostGitOperations,
bool? EnableSessionStore,
bool? EnableSkills,
bool? SuppressResumeEvent,
[property: JsonPropertyName("disableResume")] bool? SuppressResumeEvent,
bool? Streaming,
bool? IncludeSubAgentStreamingEvents,
IDictionary<string, McpServerConfig>? McpServers,
Expand Down
2 changes: 1 addition & 1 deletion nodejs/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,7 @@ export class CopilotClient {
instructionDirectories: config.instructionDirectories,
disabledSkills: config.disabledSkills,
infiniteSessions: config.infiniteSessions,
suppressResumeEvent: config.suppressResumeEvent,
disableResume: config.suppressResumeEvent,
Comment thread
willglas marked this conversation as resolved.
continuePendingWork: config.continuePendingWork,
gitHubToken: config.gitHubToken,
remoteSession: config.remoteSession,
Expand Down
3 changes: 2 additions & 1 deletion nodejs/test/e2e/suspend.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { describe, expect, it, onTestFinished } from "vitest";
import { z } from "zod";
import { approveAll, CopilotClient, defineTool, RuntimeConnection } from "../../src/index.js";
import type { PermissionRequest, PermissionRequestResult, SessionEvent } from "../../src/index.js";
import { createSdkTestContext } from "./harness/sdkTestContext.js";
import { createSdkTestContext, DEFAULT_GITHUB_TOKEN } from "./harness/sdkTestContext.js";

const SUSPEND_TIMEOUT_MS = 60_000;
const TEST_TIMEOUT_MS = 180_000;
Expand Down Expand Up @@ -65,6 +65,7 @@ describe("Suspend RPC", async () => {
const server = new CopilotClient({
workingDirectory: workDir,
env,
gitHubToken: DEFAULT_GITHUB_TOKEN,
connection: RuntimeConnection.forTcp({
path: process.env.COPILOT_CLI_PATH,
connectionToken: SHARED_TOKEN,
Expand Down
Loading