Skip to content

Fix consistency review PR delta detection #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roji wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Open

Fix consistency review PR delta detection #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sdk-consistency-review.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 11 additions & 4 deletions .github/workflows/sdk-consistency-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,19 @@ When a pull request modifies any SDK client code, review it to ensure:

## Review Process

1. **Identify the changed SDK(s)**: Determine which language implementation(s) are modified in this PR
2. **Analyze the changes**: Understand what feature/fix is being implemented
3. **Cross-reference other SDKs**: Check if the equivalent functionality exists in other language implementations:
1. **Get the authoritative PR delta**:
- Call `pull_request_read` with `method: get_files` for the PR, paginating until all changed files are retrieved
- Call `pull_request_read` with `method: get_diff` for the PR
- Treat these GitHub API responses as the only authoritative source of which changes belong to the PR, including when the PR head is a merge commit
- Base every claim about what the PR adds or modifies on the API diff; use the local checkout only for surrounding context and cross-SDK comparison
- Never infer the PR base from `HEAD^`, merge-parent ordering, recent commits, or local branch refs
- If the API file list or diff cannot be retrieved, call `missing_data` and stop; do not substitute an inferred local `git diff` range
2. **Identify the changed SDK(s)**: Determine which language implementation(s) are modified in the authoritative PR delta
3. **Analyze the changes**: Understand what feature/fix is being implemented from the authoritative PR delta
4. **Cross-reference other SDKs**: Check if the equivalent functionality exists in other language implementations:
- Read the corresponding files in other SDK directories
- Compare method signatures, behavior, and documentation
4. **Report findings**: If inconsistencies are found:
5. **Report findings**: If inconsistencies are found:
- Use `create-pull-request-review-comment` to add inline comments on specific lines where changes should be made
- Use `add-comment` to provide a summary of cross-SDK consistency findings
- Be specific about which SDKs need updates and what changes would bring them into alignment
Expand Down
Loading