Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TIP claims
tag.gpgsignrequires Git 2.23.0+, but the analogous TIP insigning-commits.mduses Git 2.0.0+ forcommit.gpgsign. Since this PR’s stated goal is parity, either align the minimum Git version here with the commits article or add a reference/justification for why tag auto-signing has a different minimum supported version (to avoid misleading readers).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake.
Git version 2.23.0 is the one that added
tag.gpgSignas a configuration variable. Sources:git's release notes for version2.23.0mentions the addition oftag.gpgSign2.23.0mentiontag.gpgSignfor the first time. Not mentioned in any previous revision (for example,2.21.0, where it is not mentioned)