Fix acceptance tests after LDAP image removal - #75
Merged
Conversation
The osixia/openldap:1.2.2 tag has been removed from Docker Hub, causing every acceptance matrix job to fail before tests start. Use the compatible, still-published 1.2.5 release from the same image series. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f94e01c-1269-46f3-bae7-353dfb70afb1
Preserve the packaged schema sources needed during image bootstrap and configure the DH parameter filename introduced after 1.2.2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f94e01c-1269-46f3-bae7-353dfb70afb1
Temporarily expose the image bootstrap diagnostics needed to identify the TLS configuration rejected by the replacement image. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f94e01c-1269-46f3-bae7-353dfb70afb1
The 1.2.5 build rejects the existing TLS fixture during bootstrap. Pin 1.2.4, the nearest available release to the removed 1.2.2 image, and restore normal LDAP logging. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f94e01c-1269-46f3-bae7-353dfb70afb1
The newer image emits a non-fatal schema conversion warning when the packaged schema sources are removed, matching the existing fixture behavior. Limit the compatibility fix to the required image and DH filename changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4f94e01c-1269-46f3-bae7-353dfb70afb1
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The image upgrade and matching TLS configuration are complete and consistent with the acceptance setup.
Review tier: Balanced
Findings: None
What changed in this PR
Updates the acceptance-test LDAP service to use an available image with compatible TLS configuration.
Changes:
- Bumps OpenLDAP from 1.2.2 to 1.2.4.
- Configures the existing DH parameter file.
| File | Description |
|---|---|
spec/acceptance/docker-compose.yml |
Updates the LDAP image version. |
spec/acceptance/ldap-server/env/default.startup.yaml |
Adds the required DH parameter filename. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trespilhas
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osixia/openldap:1.2.2tag to the still-published1.2.4tag1.2.2Root cause
All acceptance jobs failed before tests started because Docker Hub returns
manifest unknownforosixia/openldap:1.2.2.The upstream bootstrap script exists in both versions. The relevant compatibility change is that
1.2.4derives the DH parameter path fromLDAP_TLS_DH_PARAM_FILENAME, whereas1.2.2hard-codeddhparam.pem. No schema cleanup change is required.Validation
The complete acceptance matrix passes for Ruby 3.1.2, 3.2.2, 3.3.0, and 3.3.1 with the minimal two-line fix in Actions run https://github.com/github/entitlements-app/actions/runs/33794545704.