Remove test-only container lifecycle helper from production API surface by Copilot · Pull Request #4050 · github/gh-aw-firewall

Copilot · 2026-05-30T13:28:28Z

src/container-lifecycle.ts was exporting containerLifecycleTestHelpers, a test-only state mutator bundle, from a security-critical production module. This change removes that dead/public export while preserving existing test access patterns.

API surface cleanup
- Removed containerLifecycleTestHelpers export from src/container-lifecycle.ts.
- Removed test-only helper functions from the production module.
Internal state extraction
- Added src/container-lifecycle-state.ts to own the externally-killed lifecycle flag and related functions:
  - markAgentExternallyKilled
  - isAgentExternallyKilled
  - resetAgentExternallyKilled
- Updated container-lifecycle.ts to consume this internal state module.
Test-only access path retained
- Updated src/container-lifecycle.test-utils.ts to construct/export containerLifecycleTestHelpers from container-lifecycle-state.ts, so tests keep the same call shape without relying on production exports.

// src/container-lifecycle.test-utils.ts
import { isAgentExternallyKilled, resetAgentExternallyKilled } from './container-lifecycle-state';

export const containerLifecycleTestHelpers = {
  isAgentExternallyKilled,
  resetAgentExternallyKilled,
};

github-actions · 2026-05-30T13:38:14Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	96.46%	96.51%	📈 +0.05%
Statements	96.32%	96.37%	📈 +0.05%
Functions	98.26%	98.26%	➡️ +0.00%
Branches	90.61%	90.65%	📈 +0.04%

📁 Per-file Coverage Changes (2 files)

File	Lines (Before → After)	Statements (Before → After)
`src/container-lifecycle.ts`	94.0% → 93.9% (-0.11%)	94.3% → 94.2% (-0.10%)
`src/config-writer.ts`	89.3% → 90.9% (+1.65%)	89.3% → 90.9% (+1.65%)

✨ New Files (1 files)

src/container-lifecycle-state.ts: 100.0% lines

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

This PR removes a test-only lifecycle state mutator bundle (containerLifecycleTestHelpers) from the production src/container-lifecycle.ts module by extracting the externally-killed flag into a dedicated internal state module, while preserving the existing test helper access pattern via src/container-lifecycle.test-utils.ts.

Changes:

Removed containerLifecycleTestHelpers (and its underlying test-only functions) from src/container-lifecycle.ts.
Added src/container-lifecycle-state.ts to own the externally-killed lifecycle flag and its accessors/mutators.
Updated src/container-lifecycle.test-utils.ts to build containerLifecycleTestHelpers from the new state module instead of re-exporting from production code.

Show a summary per file

File	Description
src/container-lifecycle.ts	Removes test-only export and switches externally-killed checks/updates to the new state module.
src/container-lifecycle.test-utils.ts	Keeps tests’ helper import shape by constructing `containerLifecycleTestHelpers` from the extracted state module.
src/container-lifecycle-state.ts	Introduces the extracted module-scoped externally-killed flag and helper functions used by runtime + tests.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 1

+
+export function resetAgentExternallyKilled(): void {
+  agentExternallyKilled = false;
+}


lpcox · 2026-05-30T13:52:07Z

@copilot address review feedback

Copilot · 2026-05-30T14:03:33Z

@copilot address review feedback

Addressed in 802c1d3 by adding an explicit internal/test-only note on resetAgentExternallyKilled() in src/container-lifecycle-state.ts to discourage production use.

github-actions · 2026-05-30T14:06:43Z

Smoke Test: Claude Engine

✅ GitHub API: 2 recent PR entries (Remove copilotApiResolverTestHelpers from the production API surface #4051, Deduplicate server test HTTPS_PROXY/module-reset bootstrap across split api-proxy tests #4049)
✅ GitHub check: playwright_check=PASS
✅ File verify: smoke-test-claude-26685770098.txt exists

Result: PASS

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-05-30T14:07:16Z

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test	Result
GitHub MCP (list merged PRs)	✅ PR #4051 "Remove `copilotApiResolverTestHelpers`..."
GitHub.com connectivity	⚠️ Pre-step data not expanded
File write/read	⚠️ Pre-step data not expanded
BYOK inference (agent → api-proxy → api.githubcopilot.com)	✅ Responding in BYOK offline mode

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Author: @Copilot | Assignees: @lpcox, @Copilot

Overall: PARTIAL — BYOK inference and MCP confirmed ✅; pre-step outputs not injected (template vars unexpanded).

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-05-30T14:07:31Z

🔍 Smoke Test Results

Test	Result
GitHub MCP connectivity	✅ PASS
GitHub.com HTTP connectivity	⚠️ N/A (template vars not expanded)
File write/read	⚠️ N/A (template vars not expanded)

Overall: PARTIAL — MCP connectivity confirmed; pre-step outputs were not injected into the workflow template.

PR: "Remove test-only container lifecycle helper from production API surface" — author @Copilot, assignees @lpcox @Copilot.

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-05-30T14:08:55Z

🧪 Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.3`	❌ NO
Node.js	`v24.16.0`	`v22.22.3`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

Result: ❌ Not all versions match — Python and Node.js differ between host and chroot environments.

Tested by Smoke Chroot

github-actions · 2026-05-30T14:09:01Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #4050 · sonnet46 1.1M · ◷

github-actions · 2026-05-30T14:09:18Z

Remove copilotApiResolverTestHelpers from the production API surface
Deduplicate server test HTTPS_PROXY/module-reset bootstrap across split api-proxy tests
GitHub MCP review: ✅
SafeInputs GH CLI: ❌
Playwright: ✅
File write: ✅
Bash readback: ✅
Discussion comment: ✅
Build: ❌
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-05-30T14:09:32Z

Smoke Test Results

Check	Result
Redis PING	❌ No response (timeout)
PostgreSQL pg_isready	❌ `no response`
PostgreSQL SELECT 1	❌ Timeout

Overall: FAIL — host.docker.internal is not reachable from this runner environment. Service containers may not be configured or running.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-05-30T14:09:32Z

Smoke test complete.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

Initial plan

e7a6027

Copilot AI assigned Copilot and lpcox May 30, 2026

Copilot started work on behalf of lpcox May 30, 2026 13:28 View session

Copilot AI linked an issue May 30, 2026 that may be closed by this pull request

[Export Audit] Test helper containerLifecycleTestHelpers exported from production module container-lifecycle.ts #4005

Closed

fix: move lifecycle test helpers from prod export

aeafcb1

Copilot AI changed the title ~~[WIP] Remove test helper from production module container-lifecycle.ts~~ Remove test-only container lifecycle helper from production API surface May 30, 2026

Copilot finished work on behalf of lpcox May 30, 2026 13:34

Copilot AI requested a review from lpcox May 30, 2026 13:34

lpcox marked this pull request as ready for review May 30, 2026 13:36

Copilot AI review requested due to automatic review settings May 30, 2026 13:36

Copilot started reviewing on behalf of lpcox May 30, 2026 13:37 View session

This comment has been minimized.

Sign in to view

github-actions Bot added smoke-claude smoke-copilot labels May 30, 2026

This comment has been minimized.

Sign in to view

Copilot AI reviewed May 30, 2026

View reviewed changes

Comment thread src/container-lifecycle-state.ts

Comment on lines +10 to +13

export function resetAgentExternallyKilled(): void {

agentExternallyKilled = false;

}

github-actions Bot added the build-test label May 30, 2026

This comment has been minimized.

Sign in to view

Copilot started work on behalf of lpcox May 30, 2026 13:59 View session

docs: mark lifecycle reset helper as test-only internal

802c1d3

Copilot finished work on behalf of lpcox May 30, 2026 14:04

github-actions Bot added the smoke-gemini label May 30, 2026

lpcox merged commit b1a31c5 into main May 30, 2026
62 of 64 checks passed

lpcox deleted the copilot/remove-test-helper-export branch May 30, 2026 14:45

lpcox mentioned this pull request May 31, 2026

[Export Audit] Dead exports resetAgentExternallyKilled and aggregateLogs only consumed by test files (regression) #4097

Closed

Conversation

Copilot AI commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Coverage Check Passed

Overall Coverage

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lpcox commented May 30, 2026

Uh oh!

Copilot AI commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Smoke Test: Claude Engine

Uh oh!

github-actions Bot commented May 30, 2026

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Uh oh!

github-actions Bot commented May 30, 2026

🔍 Smoke Test Results

Uh oh!

github-actions Bot commented May 30, 2026

🧪 Chroot Version Comparison Results

Uh oh!

github-actions Bot commented May 30, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 30, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 30, 2026 •

edited

Loading

github-actions Bot commented May 30, 2026 •

edited

Loading