Unexport LINUX_CAPABILITY_MAP from capability-filter.ts - #7928
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused API cleanup follows established repository conventions without changing runtime behavior.
Pull request overview
Makes the Linux capability map private while retaining test access through the established internal helper convention.
Changes:
- Removes the direct
LINUX_CAPABILITY_MAPexport. - Updates unit tests to access it through
testHelpers.
File summaries
| File | Description |
|---|---|
src/capability-filter.ts |
Privatizes the map and adds a test-only helper export. |
src/capability-filter.test.ts |
Uses testHelpers for map assertions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤
|
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
✅ Smoke Claude passed Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
✅ Build Test Suite completed successfully!
|
|
✅ Contribution Check completed successfully! No contribution-guideline issues found in PR #7928. The change is small, stays in src/, includes a matching unit test update, updates the PR description with a related issue reference, and does not require documentation changes.
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (api.github.com) reachable — HTTP 200 Overall: PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
Smoke Test: Copilot BYOK (Direct) Mode✅ PASS — All tests successful
Running in direct BYOK mode with
|
|
Smoke Test: Copilot Engine
Overall: PASS
|
|
Smoke Test: GitHub Actions Services Connectivity — FAIL
Overall: FAIL — DNS resolution for
|
Smoke Test
Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
Smoke Test: Docker Sbx Validation
Overall: PASS cc
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version mismatch between host and chroot environments.
|
📡 OTel Tracing Smoke Test Results
Overall: All 5 scenarios pass. No regressions detected in OTel tracing integration.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
|
PR Titles:
GitHub MCP Testing: ❌ (expected #7929/#7927) Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) Overall Status: FAIL
|
|
✅ GitHub MCP test Note: Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: PASS
|
LINUX_CAPABILITY_MAPwas exported fromsrc/capability-filter.tsbut only ever consumed internally byfilterCapDrop(), unnecessarily widening the public API of a security-critical module.Changes
exportfromLINUX_CAPABILITY_MAP, making it a private implementation detail offilterCapDrop().testHelpersconvention (@internal+ts-prune-ignore-next) instead of a direct export.capability-filter.test.tsto pull the map fromtestHelpersrather than importing it directly.