Fix context cancel lifecycle violations in workflow + MCP inspect paths#35811
Merged
pelikhan merged 4 commits intoMay 29, 2026
Merged
Conversation
5 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix context cancel function defer violations
Fix context cancel lifecycle violations in workflow + MCP inspect paths
May 29, 2026
Collaborator
|
@copilot the explicit cancel too |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
pelikhan
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LintMonster flagged 6
contextcancelnotdeferredfindings where cancel funcs fromcontext.WithTimeoutwere not deferred immediately after creation. This updates the affected call sites to follow the required context lifecycle pattern without changing behavior.Workflow resolver: annotated tag peel timeout
/pkg/workflow/action_resolver.goto deferpeelCancel()immediately aftercontext.WithTimeout(...)in the tag-peeling loop.Safe outputs: remote action YAML fetch timeout
/pkg/workflow/safe_outputs_actions.goto defercancel()immediately after timeout context creation infetchRemoteActionYAML.CLI MCP inspect: operation-scoped contexts
/pkg/cli/mcp_inspect_mcp.goat all reportedListTools/ListResourcestimeout contexts (stdio + HTTP paths) to defer cancellation immediately after context creation.Example pattern applied: