fix: sync pkg/linters/doc.go to 51 analyzers and add drift guard test by Copilot · Pull Request #46138 · github/gh-aw

Copilot · 2026-07-17T06:05:45Z

pkg/linters/doc.go claimed // All 45 active analyzers: with 45 bullets while cmd/linters/main.go registered 51 — a recurring drift class (#40436, #45185).

Changes

pkg/linters/doc.go — header updated to 51; 6 missing bullets added in alphabetical order: bytesbufferstring, ioutildeprecated, logfatallibrary, mapclearloop, mapdeletecheck, stringscountcontains
pkg/linters/doc_sync_test.go (new) — TestDocGo_CountMatchesBullets parses doc.go at test time, extracts the // All N active analyzers: count, and asserts it equals the number of // - bullet lines. Prevents silent re-drift without requiring any imports of the registered analyzers.
pkg/linters/spec_test.go — the 5 newly-tracked analyzers (bytesbufferstring, ioutildeprecated, logfatallibrary, mapclearloop, mapdeletecheck) added to documentedAnalyzers(); count comment updated from 41 → 46. (stringscountcontains was already present.)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-07-17T06:55:35Z

@copilot merge main and recompile

github-actions · 2026-07-17T06:55:58Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions · 2026-07-17T06:56:02Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #46138 does not have the 'implementation' label and has only 72 new lines of code in business logic directories (threshold: 100).

github-actions · 2026-07-17T06:56:02Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-17T06:56:05Z

✅ Test Quality Sentinel completed test quality analysis.

Copilot

Pull request overview

Synchronizes linter documentation with the 51 registered analyzers and adds a drift test.

Changes:

Adds six missing analyzer descriptions.
Expands analyzer specification coverage.
Regenerates workflow artifacts and reschedules auto-upgrade.

Show a summary per file

File	Description
`pkg/linters/doc.go`	Updates analyzer inventory to 51.
`pkg/linters/doc_sync_test.go`	Adds documentation count validation.
`pkg/linters/spec_test.go`	Expands tracked analyzers.
`.github/workflows/skillet.lock.yml`	Regenerates action metadata.
`.github/workflows/release.lock.yml`	Regenerates action metadata.
`.github/workflows/hourly-ci-cleaner.lock.yml`	Regenerates action metadata.
`.github/workflows/avenger.lock.yml`	Regenerates action metadata.
`.github/workflows/agentic-auto-upgrade.yml`	Changes the weekly schedule.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 8/8 changed files
Comments generated: 7
Review effort level: Medium

+	assert.Equal(t, headerCount, bulletCount,
+		"doc.go header says %d analyzers but %d bullet entries were found; "+
+			"update the header or add/remove the missing bullets",
+		headerCount, bulletCount)


 // documentedAnalyzers returns the analyzer subpackages documented in the README
-// "Public API > Subpackages" table. The README documents 41 analyzers
+// "Public API > Subpackages" table. The README documents 46 analyzers
 // subpackages (the non-analyzer `internal` helper subpackage is excluded because
 // it exposes no Analyzer).


          GH_AW_INFO_ENGINE_ID: "copilot"
      - name: Checkout skills directory
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0


          echo "GH_HOST=${GH_HOST}" >> "$GITHUB_ENV"
      - name: Checkout repository
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0


          echo "GH_HOST=${GH_HOST}" >> "$GITHUB_ENV"
      - name: Checkout repository
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0


          RELEASE_TAG: ${{ needs.config.outputs.release_tag }}
      - name: Setup Go
-        uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
+        uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # b7ad1dad31e06c5925ef5d2fc7ad053ef454303e


 on:
  schedule:
-    - cron: "11 4 * * 6"  # Weekly (auto-upgrade)
+    - cron: "21 3 * * 5"  # Weekly (auto-upgrade)


github-actions

Skills-Based Review 🧠

Applied /tdd — one fixable issue found; otherwise solid work.

📋 Key Themes & Highlights

Issue

assert.Equal arg order in doc_sync_test.go:47: testify's signature is (t, expected, actual). headerCount (the declared value) should be first; bulletCount (the observed value) second. Currently reversed, so failure messages are misleading.

Positive Highlights

✅ New TestDocGo_CountMatchesBullets is a clean, import-free drift guard — exactly the right level of abstraction.
✅ Six missing analyzers correctly backfilled in alphabetical order in both doc.go and spec_test.go.
✅ spec_test.go uses require.NoError appropriately for setup-phase failures.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 28.7 AIC · ⌖ 6.88 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions · 2026-07-17T07:04:02Z

+	require.NoError(t, scanner.Err())
+	require.True(t, foundHeader, "doc.go must contain an '// All N active analyzers:' header")
+
+	assert.Equal(t, headerCount, bulletCount,


[/tdd] assert.Equal argument order is reversed — testify convention is assert.Equal(t, expected, actual, msg). Here headerCount is the declared (expected) value and bulletCount is the actual observed count, so the arguments should be swapped. With the current order, a failure message reads "expected: 51, got: 47" when the header is the stale value — confusing during triage.

💡 Suggested fix

// current (wrong order): assert.Equal(t, headerCount, bulletCount, "doc.go header says %d analyzers but %d bullet entries were found; ...", headerCount, bulletCount) // correct order: assert.Equal(t, bulletCount, headerCount, "doc.go header says %d analyzers but %d bullet entries were found; ...", headerCount, bulletCount)

@copilot please address this.

github-actions

Review: sync pkg/linters/doc.go to 51 analyzers

The drift guard test (TestDocGo_CountMatchesBullets) is a good addition and correctly catches doc.go header/bullet mismatches. However, spec_test.go's documentedAnalyzers() was only partially updated — it still covers 46 of the 51 analyzers.

Blocking issue: 5 analyzers in doc.go are missing from spec_test.go's documentedAnalyzers(): bytescomparestring, httprespbodyclose, httpstatuscode, osgetenvlibrary, sprintfint. They will be silently excluded from spec coverage.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 36.1 AIC · ⌖ 4.43 AIC · ⊞ 5K

github-actions · 2026-07-17T07:04:11Z


 // documentedAnalyzers returns the analyzer subpackages documented in the README
-// "Public API > Subpackages" table. The README documents 41 analyzers
+// "Public API > Subpackages" table. The README documents 46 analyzers


github-actions · 2026-07-17T07:04:11Z


 // documentedAnalyzers returns the analyzer subpackages documented in the README
-// "Public API > Subpackages" table. The README documents 41 analyzers
+// "Public API > Subpackages" table. The README documents 46 analyzers


Missing analyzers in documentedAnalyzers()

The comment says "46 analyzers" but doc.go now declares 51. Five analyzers documented in doc.go's bullet list are absent from documentedAnalyzers():

bytescomparestring

httprespbodyclose

httpstatuscode

osgetenvlibrary

sprintfint

The new TestDocGo_CountMatchesBullets drift guard checks that doc.go's header count matches its bullet list — but there's no guard ensuring spec_test.go's documentedAnalyzers() covers all 51. These five analyzers will be silently skipped by the spec test.

Please add the missing imports and docAnalyzer entries, and update the comment to say "51 analyzers". @copilot please address this.

github-actions · 2026-07-17T07:04:41Z

🧪 Test Quality Sentinel Report

⚠️ Test Quality Score: 77/100 — Acceptable

Analyzed 9 test(s): 8 design, 1 implementation, 0 violation(s).

📊 Metrics (9 tests)

Metric	Value
Analyzed	9 (Go: 9, JS: 0)
✅ Design	8 (89%)
⚠️ Implementation	1 (11%)
Edge/error coverage	5 (56%)
Duplicate clusters	1
Inflation	NO
🚨 Violations	0

Test	File	Classification	Issues
`TestDocGo_CountMatchesBullets`	`doc_sync_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_PublicAPI_SubpackageAnalyzers`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_NamespaceExports_ErrorMessageAnalyzer`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_Constants_DefaultMaxParams`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_Constants_DefaultMaxLines`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_DesignDecision_MaxParamsFlag`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_DesignDecision_MaxLinesFlag`	`spec_test.go`	design_test / behavioral_contract / high_value	None
`TestSpec_UsageExample_AnalyzersUsable`	`spec_test.go`	implementation_test / duplicated / low_value	Partially duplicates TestSpec_PublicAPI_SubpackageAnalyzers
`TestSpec_DesignDecision_UniqueAnalyzerNames`	`spec_test.go`	design_test / behavioral_contract / high_value	None

⚠️ Flagged Tests (1)

TestSpec_UsageExample_AnalyzersUsable (spec_test.go) — implementation_test, partially duplicated. This test iterates documentedAnalyzers() and asserts non-nil, which is already checked in TestSpec_PublicAPI_SubpackageAnalyzers. The "usage example" intent is documented in comments but the assertion body overlaps. Consider removing or converting to a compile-only check.

Verdict

✅ Passed. 11% implementation tests (threshold: 30%). Both new test files have //go:build !integration build tags. No mock library violations. TestDocGo_CountMatchesBullets is a high-value drift guard enforcing an invariant that previously caused silent doc rot. TestSpec_PublicAPI_SubpackageAnalyzers is a well-structured table-driven spec test covering 46 subpackages.

References: §29561445385

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🧪 Test quality analysis by Test Quality Sentinel · 28.1 AIC · ⌖ 13.7 AIC · ⊞ 6.8K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 77/100. 11% implementation tests (threshold: 30%). No violations.

github-actions

Two issues need attention

The bullet-count drift guard (TestDocGo_CountMatchesBullets) is a solid addition. Two issues found:

📋 Findings summary

1. Unanchored header regex (medium) — doc_sync_test.go line 26: the pattern // All (\d+) active analyzers: has no ^/$ anchors. Any line that contains that substring will silently overwrite headerCount, potentially masking a real mismatch.

2. documentedAnalyzers() gap widens (high) — doc.go now lists 51 analyzers; spec_test.go has 46 entries. The 5 uncovered analyzers (bytescomparestring, httprespbodyclose, httpstatuscode, osgetenvlibrary, sprintfint) are never validated by TestSpec_PublicAPI_SubpackageAnalyzers. This PR adds 6 bullets to doc.go but only 5 entries to spec_test.go, growing the gap 4 → 5. The new count-match test passes, but spec coverage remains incomplete.

🔎 Code quality review by PR Code Quality Reviewer · 59 AIC · ⌖ 4.55 AIC · ⊞ 5.6K
_{Comment /review to run again}

github-actions · 2026-07-17T07:05:52Z

+	require.NoError(t, err, "doc.go must be present in pkg/linters")
+	defer f.Close() //nolint:errcheck
+
+	headerRe := regexp.MustCompile(`// All (\d+) active analyzers:`)


Unanchored header regex can silently over-match: // All (\d+) active analyzers: has no ^ anchor, so any comment line containing this substring could match, silently overwriting headerCount.

💡 Suggested fix

headerRe := regexp.MustCompile(`^// All (\d+) active analyzers:$`)

With anchors, only the canonical header line matches. A line like // see // All 45 active analyzers: was wrong would otherwise match and corrupt the count.

github-actions · 2026-07-17T07:05:52Z

 //	regexpcompileinfunction, seenmapbool, sortslice, sprintferrdot, sprintferrorsnew, ssljson,
 //	strconvparseignorederror, stringreplaceminusone, stringscountcontains, stringsindexcontains, timeafterleak, timesleepnocontext,
 //	tolowerequalfold, uncheckedtypeassertion, wgdonenotdeferred, writebytestring
 func documentedAnalyzers() []docAnalyzer {


documentedAnalyzers() is missing 5 analyzers listed in doc.go: doc.go now documents 51 analyzers; spec_test.go has 46 entries. The 5 missing analyzers (bytescomparestring, httprespbodyclose, httpstatuscode, osgetenvlibrary, sprintfint) are never exercised by TestSpec_PublicAPI_SubpackageAnalyzers or TestSpec_DocumentedAnalyzersHaveSubpackages.

💡 Details

This PR adds 6 new bullets to doc.go but only adds 5 analyzers to documentedAnalyzers(). The gap was already 4 before this PR; it's now 5. The TestDocGo_CountMatchesBullets test added in this PR will pass (51 == 51 bullets) but the spec coverage test continues to silently under-cover these analyzers. Adding the missing 5 entries to documentedAnalyzers() would close the gap.

github-actions · 2026-07-17T07:12:52Z

🤖 PR Triage

Field	Value
Category	`chore`
Risk	`low`
Score	35/100 (impact:10, urgency:10, quality:15)
Action	`auto_merge`

Rationale: Pure doc sync — updates pkg/linters/doc.go from 45→51 analyzers and adds drift guard test. Low risk, CI running. Auto-merge when CI passes.

Generated by 🔧 PR Triage Agent · 166.4 AIC · ⌖ 6.15 AIC · ⊞ 5.6K · ◷

…analyzer-count Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-17T07:24:25Z

@copilot merge main and recompile

Done in de90287 — merged main into this branch and recompiled workflow lock files.

Initial plan

7d75d57

Copilot AI assigned Copilot and pelikhan Jul 17, 2026

Copilot started work on behalf of pelikhan July 17, 2026 06:06 View session

Copilot AI linked an issue Jul 17, 2026 that may be closed by this pull request

doc-sync: pkg/linters/doc.go says "45 active analyzers" but 51 are registered — 6 newest linters omitted #46131

Closed

4 tasks

Copilot AI and others added 2 commits July 17, 2026 06:13

chore: plan doc.go sync fix

b00e096

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

fix: sync pkg/linters/doc.go to 51 analyzers and add drift guard test

90ce8ec

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix doc.go to match registered analyzers count~~ fix: sync pkg/linters/doc.go to 51 analyzers and add drift guard test Jul 17, 2026

Copilot finished work on behalf of pelikhan July 17, 2026 06:28

Copilot AI requested a review from pelikhan July 17, 2026 06:28

pelikhan marked this pull request as ready for review July 17, 2026 06:55

Copilot AI review requested due to automatic review settings July 17, 2026 06:55

Copilot started reviewing on behalf of pelikhan July 17, 2026 06:55 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Copilot started work on behalf of pelikhan July 17, 2026 07:01 View session

github-actions Bot mentioned this pull request Jul 17, 2026

[aw] No-Op Runs #43499

Open

github-actions Bot reviewed Jul 17, 2026

View reviewed changes

github-actions Bot requested changes Jul 17, 2026

View reviewed changes

github-actions Bot approved these changes Jul 17, 2026

View reviewed changes

github-actions Bot reviewed Jul 17, 2026

View reviewed changes

github-actions Bot added pr-action:auto_merge pr-agent:copilot pr-priority:low pr-risk:low labels Jul 17, 2026

github-actions Bot added the pr-type:chore label Jul 17, 2026

Copilot AI and others added 2 commits July 17, 2026 07:13

Merge remote-tracking branch 'origin/main' into copilot/doc-sync-fix-…

81f156a

…analyzer-count Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

chore: merge main and recompile lock files

de90287

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 17, 2026 07:25

pelikhan merged commit a4da0c5 into main Jul 17, 2026
29 checks passed

pelikhan deleted the copilot/doc-sync-fix-analyzer-count branch July 17, 2026 11:18

This was referenced Jul 17, 2026

Smoke Test: MAI-Code-1-Flash - 29576465286 #46209

Closed

Smoke Test: MAI-Code-1-Flash - 29576602132 #46212

Closed

Smoke Test: MAI-Code-1-Flash - 29576796953 #46219

Open

[spec-librarian] Specification Audit — 2026-07-17 — 9 issues found #46256

Open

Copilot AI mentioned this pull request Jul 17, 2026

Refresh stale package specs and add linters doc drift guard #46257

Draft

Uh oh!

Conversation

Copilot AI commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pelikhan commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Issue

Positive Highlights

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review: sync pkg/linters/doc.go to 51 analyzers

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 17, 2026

🧪 Test Quality Sentinel Report

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Two issues need attention

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 17, 2026

🤖 PR Triage

Uh oh!

Copilot AI commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading