Skip to content

[review] fix(setup-js): wrap all sync fs calls in try/catch (eslint-monster remediation)#46217

Closed
github-actions[bot] wants to merge 12 commits into
mainfrom
copilot/eslint-monster-wrap-fs-calls-review-1784287803551
Closed

[review] fix(setup-js): wrap all sync fs calls in try/catch (eslint-monster remediation)#46217
github-actions[bot] wants to merge 12 commits into
mainfrom
copilot/eslint-monster-wrap-fs-calls-review-1784287803551

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Reason: agent_failure

Review the workflow run logs for details.

This PR contains changes that were originally intended for PR #46102 (copilot/eslint-monster-wrap-fs-calls).
Please review the changes carefully before merging.

Copilot AI and others added 12 commits July 17, 2026 00:02
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolve conflict in .github/workflows/release.lock.yml:
- Keep v7.0.0 version tag for actions/setup-go from our branch
- Incorporate main's format change (manifest header on single line)
- Pick up mai-code-1-flash-picker model addition and other main changes

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…rkflows

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- upload_artifact.cjs: wrap copyFileSync in try/catch with descriptive error
- evaluate_outcomes.cjs: wrap renameSync in try/catch with descriptive error
- start_mcp_gateway.cjs: wrap chmodSync(configDir) and chmodSync(outputPath)
  in try/catch; wrap both copyFileSync fallback/else branches in try/catch
- convert_gateway_config_shared.cjs: move chmodSync inside existing try/catch
- action_setup_otlp.cjs: move success log inside try so it only fires on success
- detect_agent_errors.cjs: emit stderr warning instead of silently ignoring
  GITHUB_OUTPUT write failures

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…r-wrap-fs-calls

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor Author

Thanks for keeping this narrowly scoped to the sync fs error-handling remediation and for including a concise changeset summary.

This repo's CONTRIBUTING.md says non-core contributors should not open direct PRs; contributions are expected to come through issues/agentic plans, with core team members creating implementation PRs. This PR also appears to be authored by automation while GitHub reports the PR author association as CONTRIBUTOR, so it needs a process check before review can proceed.

Additional improvement: the diff only adds a changeset file and does not include test-file changes, so reviewers may need confirmation that coverage already exists or that tests were intentionally unnecessary.

Review PR #46217 against the repository contribution process. Confirm whether the author is part of the core team or whether this PR should be closed and re-routed through an issue-based agentic plan. If the code change is still desired, prepare a compliant follow-up PR from a core-team workflow and include or reference tests that validate the sync fs try/catch behavior.

Generated by ✅ Contribution Check · 80.9 AIC · ⌖ 8.97 AIC · ⊞ 6.2K ·

Base automatically changed from copilot/eslint-monster-wrap-fs-calls to main July 18, 2026 05:27
@pelikhan pelikhan closed this Jul 18, 2026
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 7.57 AIC · ⌖ 7.54 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants