-
Notifications
You must be signed in to change notification settings - Fork 528
Clarify fallback issue paths for manual PR creation #56572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4d434b2
807233d
c3d474a
acec230
1e9286b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,23 @@ | ||
| {body} | ||
| > [!TIP] | ||
| > **Your pull request is ready to create! 🎉 ✅** | ||
| > | ||
| > Everything is OK—the changes have been pushed to branch `{branch_name}`. Please review the changes, including any protected files, before creating the pull request. | ||
| > | ||
| > **[Create the pull request]({create_pr_url})** | ||
| > | ||
| > The original pull request description is below. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed the permission-denied fallback to pass the footer-free main body and footer separately, placing the permission guidance before the footer. Added ordering regression coverage. Commit: |
||
|
|
||
| --- | ||
|
|
||
| {main_body} | ||
|
|
||
| --- | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [/codebase-design] The 💡 Suggested fixAdd a brief reassurance sentence: > [!NOTE]
> GitHub Actions is not permitted to create or approve pull requests in this repository.
> The changes have been pushed to branch `{branch_name}` and are ready to review.This keeps the two templates symmetric and ensures users understand the state of their changes. @copilot please address this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added explicit guidance that the pushed changes are ready for review in the permission-denied fallback note. Commit: |
||
|
|
||
| > [!NOTE] | ||
| > This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository. | ||
| > The changes have been pushed to branch `{branch_name}`. | ||
| > | ||
| > **[Click here to create the pull request]({create_pr_url})** | ||
| > GitHub Actions is not permitted to create or approve pull requests in this repository. | ||
|
|
||
| > The changes have been pushed to branch `{branch_name}` and are ready to review. | ||
|
|
||
| To fix the permissions issue, go to **Settings** → **Actions** → **General** and enable **Allow GitHub Actions to create and approve pull requests**. See also: [gh-aw FAQ]({faq_url}){patch_preview} | ||
|
|
||
| {footer} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd] The regression test covers the protected-file fallback body ordering, but there is no parallel test for
pr_permission_denied_fallback.md— leaving that template's new heading order unverified.💡 Suggested approach
Add equivalent
indexOf-ordering assertions in the permission-denied fallback test, similar to the four lines added here:This ensures both fallback paths stay consistent as the templates evolve.
@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added parallel permission-denied fallback assertions covering tip → original body → permission details → footer ordering. Commit:
$(git rev-parse --short HEAD).