Repository navigation
fix(test): update sub-agent smoke fixture for renamed mini54-whoami - #70355
Merged
Merged
Conversation
#70328 renamed the nano-whoami sub-agent in smoke-copilot-sub-agents.md to mini54-whoami (gpt-5.4-mini), but smoke_copilot_sub_agents.test.cjs still built evidence for nano-whoami, so two tests fail on main and in every PR's JS shards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The isolated, test-only correction matches the workflow’s agent, model, and endpoint expectations.
No open issues 🎉
What changed in this PR
Updates the Copilot sub-agent smoke-test fixture to match the workflow rename from #70328.
Changes:
- Replaces
nano-whoamiongpt-5-nanowithmini54-whoamiongpt-5.4-mini, preserving the/responsesendpoint.
| File | Description |
|---|---|
| actions/setup/js/smoke_copilot_sub_agents.test.cjs | Aligns test evidence with the renamed sub-agent and model. |
Review effort: Max
Collaborator
Author
|
Verification at |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a test break on
maincaused by our #70328, which renamed thenano-whoamisub-agent insmoke-copilot-sub-agents.mdtomini54-whoami(gpt-5.4-mini) without updatingsmoke_copilot_sub_agents.test.cjs. Two tests in that file have failed since (for example in the JS shards of #70294 and #70325):mini54-whoami must actually run exactly once.One-line change: the test's evidence fixture now builds
mini54-whoamioncopilot-responses/gpt-5.4-mini.npx vitest run smoke_copilot_sub_agents.test.cjs: 8/8 pass.#70295 carries the identical change (commit 9f39165), so it merges cleanly after this.