CI against Ruby v3.4 and v4.0 - #313
Open
meganemura wants to merge 2 commits into
Open
Conversation
Ruby 3.4+ renders backtrace locations with a plain quote (in 'block...') instead of the older backtick+apostrophe style (in `block...'), which broke this assertion when testing against newer Rubies.
There was a problem hiding this comment.
🟢 Approval recommended
The focused compatibility changes are correct and introduce no unresolved issues.
Pull request overview
Adds CI coverage for Ruby 3.4 and 4.0 while accommodating Ruby’s updated backtrace quoting.
Changes:
- Adds Ruby 3.4 and 4.0 to the CI matrix.
- Accepts legacy and current backtrace quote styles.
File summaries
| File | Description |
|---|---|
.github/workflows/ci.yml |
Expands tested Ruby versions. |
test/scientist/experiment_test.rb |
Updates backtrace assertion compatibility. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 and 4.0 are out, so this adds both to the CI matrix.
Ruby 3.4 also changed backtrace quoting (
in 'block', previouslyin `block'), so the mismatch backtrace test now accepts both styles.