Skip to content

fix(app): keep Merge and Close pending until GitHub reports the pull request settled - #597

Merged
iamnbutler merged 2 commits into
mainfrom
fix-pr-refresh
Oct 22, 2026
Merged

iamnbutler merged 2 commits into
mainfrom
fix-pr-refresh

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Map ^710. After Merge PR or Close PR from the app, the action's pending state ended with the agent's run, so the actions fell back to the last pull request read (still open) and Merge PR came back until the next read; the map saw it for about 25 s.

  • While Merge or Close is pending, the shown channel's pull request is read every 3 s instead of every 60 s.
  • When the run ends, Merge and Close stay pending until GitHub reports the pull request merged or closed. If it stays open (GitHub refused), the pending state ends 15 s after the run, so Merge PR returns.

Smoke, isolated host on port 4761 from this lane, githubnext/ace-testbed, headless Playwright at 1280:

  • PR githubnext/ace-testbed#8: clicked Merge PR in the details sidebar. Merging showed until the PR read as merged; Merge PR never reappeared.
  • PR githubnext/ace-testbed#9: clicked Merge PR options → Close PR. It showed Closing PR for 8 s, then Create PR. Polled each second for 22 s, and Merge PR or Close PR never came back.

Built in Ace

No. Built by Claude Code as a fix-train worker for the ace-map review, with Playwright for the smoke, because the train runs outside an Ace channel. Dogfooding gap tracked in #5.

@iamnbutler
iamnbutler merged commit 071dd0a into main Oct 22, 2026
1 check passed
@iamnbutler
iamnbutler deleted the fix-pr-refresh branch October 22, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant