Repository navigation
fix(channel): ask before staging unrelated work when lane push refuses - #598
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map ^708. When
lane pushrefused because of uncommitted and untracked work, the channel's agent rangit add -Aand committed a binary and a 150-file folder as "Lane context", without asking. The agent's lane instructions (packages/channel/src/room.ts) now say: never stage everything (git add -A,git add .,git commit -a) to get past that refusal; commit only files known to belong to the work, by path, and for the rest stop, list them, and ask the person.Smoke, isolated host on port 4762 from this lane, githubnext/ace-testbed: the agent started lane
saturnand committedhello saturn. I then added an uncommitted README.md line, an untracked 200 KBrecording.movandscratch/with 150 files, and sent the app's Push request text.lane pushrefused, and the agent asked a question that named README.md's edit, recording.mov and scratch/ (150 files). It offered stash, commit README.md only, discard, or stop. I answered "Stop, don't push". Nothing was committed or pushed, and the files were left as they were.Built in Ace
No. Built by Claude Code as a fix-train worker for the ace-map review because the train runs outside an Ace channel. Dogfooding gap tracked in #5.