Repository navigation
fix(host): say what say, stop, rename, archive and other commands did, and ask before deleting a busy channel - #661
Merged
Merged
Conversation
…, and ask before deleting a busy channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several CLI commands printed nothing on success, and
ace deleteremoved a channel with a run in progress without asking.say→Posted to <channel>.ask --detach→Asked <channel>'s agent; the run continues. Follow it with: ace watch <channel>answer→Answered the question in <channel>.stop→Stopped the run in <channel>.orNothing was running in <channel>., based on the chat's state before the stoprename→Renamed <old> to <new>.archive→Archived <channel>. Resume it with: ace unarchive <channel>unarchive→Unarchived <channel>.desktop … off→Desktop tools are off for <channel>. Its agents' new desktop calls are refused.ace deleteon a channel with a run in progress asks<channel> has a run in progress. Delete it anyway? [y/N]in a terminal. Without a terminal it refuses and names--yes, which skips the question.ace lsandace ls --teamstart with a header row.Not in this PR:
ace lsstill showsrunningfor a channel whose worker is up with no run. docs/terms.md only defines Dormant and avoids "idle", so a word for that state needs a terms decision. Also not here:--team's column order, and the serve, demo and--versionitems in #625. Part of #625. Map: ^422, ^449.Smoke: loopback source host with its own
ACE_HOME, real model.new/say/stop/rename/archive/unarchive/desktop offon a new channel printed each line above.stopwith nothing running said so.ace lsandace ls --teamprinted their header rows.ask --detach "Run 'sleep 60'…"printed its line.ace deletethen refused without a terminal (exit 1).stopprintedStopped the run in clisaid.anddelete --yesdeleted a busy channel.yto the delete question deleted the channel.answerwas not exercised (it needs a waiting question).Built in Ace
No: made from Claude Code (a fix-train worker), using the CLI for the smoke test. Dogfooding gap tracked in #5.