Repository navigation
fix(app): withhold Terminal from a teammate's channel and say where its terminals open - #662
Merged
Merged
Conversation
…ts terminals open Why: apps/app/src/channel.tsx#function Channel | only this host's own local channels offer Terminal; saved Terminal tabs elsewhere show where terminals open instead of an empty pane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only this host's own local channels offer Terminal now: the New tab menu and a split's blank-pane chooser list Chat and Diff for a teammate's, hosted, or cloud channel. A Terminal tab saved there earlier no longer opens a blank, focused xterm with a corner chip; it shows a centered line saying where terminals open, e.g. "Terminals open on the channel's host, natembp, and only for its owner." Whether teammates should get terminals (#11) is untouched.
Fixes #629. Map: ^779.
Smoke: two isolated source hosts on one Mac (own ACE_HOME/config/keychain, ports 4371/4372), host A seeing host B as a tailnet peer under another machine name. In headless Chromium on A: own channel's New tab menu lists Chat, Diff, Terminal and the terminal runs
echowith output; B's channelbee · natembplists only Chat, Diff; a saved Terminal tab on it shows the message, with no xterm and nothing focused.Built in Ace
No. Made from Claude Code (a fix-train worker), with headless Playwright for the smoke; see #5.