Repository navigation
fix(host): list the GitHub CLI and its sign-in in Host tools and the setup checks - #663
Merged
Merged
Conversation
…setup checks Why: apps/app/src/team-setup.tsx#function Checks | hello's GitHub login can arrive before gh answers and isn't resent, so the setup check reads gh's sign-in from diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh auth status --hostname github.com --json hostswith the same token and environment the host's otherghcalls use (now shared asgithub.environment()).gh auth loginagain.Checks) reads that entry. It says "install GitHub CLI, then rungh auth login" when gh is missing, and showsGitHub · <login>from gh. Before this change, a fresh host's welcome said "GitHub: run gh auth login" even when signed in, becausehello's login arrived before gh answered and was never sent again.Map: ^6, ^742. Part of #540: this PR adds the check. The access, avatar and dashboard effects listed in the issue are unchanged.
Smoke:
bun types,bun run ci.ACE_HOME, then checked the first-run welcome and Settings → Host in headless Chromium:✓ GitHub · iamnbutlerin the welcome, and "Signed in as iamnbutler" in Tools.ghoff PATH:! GitHub: install GitHub CLI, then run gh auth login, and Tools shows Not found with the install message.ghstub that prints gh's own signed-out JSON,{"hosts":{}}):! GitHub: run gh auth login, and Tools shows the sign-in message.Built in Ace
No: made from Claude Code (a fix-train worker), using headless Chromium for the smoke test. Dogfooding gap tracked in #5.