Repository navigation
fix(ui): show each grouped message's time beside its bubble - #667
Merged
Merged
Conversation
Why: packages/ui/src/components/timeline/layout.ts#function itemHeight | bubble rows measure at content - STAMP; GroupRows must reserve the same STAMP or heights drift from the render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages grouped under one header now show their own time when it differs from the one before and from the header's (which shows the last message's time). The time sits outside the bubble, opposite the avatar, in room every grouped bubble now reserves (52px), so heights stay measured exactly and long messages don't re-wrap when a group grows. Hovering a message still switches the header to its exact time.
Fixes #602 (the New divider and mention highlight landed earlier; this is the rest).
Map: ^903 (https://ace-map.iamnbutler.pages.nexthub.sh/conversation.html#903)
Smoke: own
ace serve --loopback(isolated ACE_HOME, port 4166) with an imported seed of grouped messages at 9:20, 9:23, 9:23, 9:24 from a teammate and 9:30, 9:32 (long, wrapping), 9:34 from me. At 1300px and 640px wide the first group showed 9:20 and 9:23 beside their bubbles with 9:24 in the header, my group showed 9:30 and 9:32 (beside the full-width wrapped bubble, within the reserved room), and a single-message group showed none.Built in Ace
No. Made from Claude Code (fix-train worker), with a headless browser for the smoke screenshots, because the fix train runs outside Ace. Gap tracked in the dogfooding meta issue #5.