Repository navigation
fix(app): ask an empty Git repository for its first commit, not git init - #668
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A folder that's already a Git repository but has no commit showed "Initialize a Git repository to get started" and promised to run
git init. The host now marks such a projectempty, and the Initialize Git card then reads "Make the first commit to get started". It says the folder has no commit yet, drops thegit initwording, and its button reads "Make first commit" ("Committing…" while it runs, then the toast "Made the first commit"). If the folder already has its own.gitignore, the card says to commit its files yourself and no longer tells you to rungit init. Folders without.gitkeep the old card.Smoke-tested on a loopback source host (own ACE_HOME, port 4377) in headless Chromium with three folders:
git initwith no commit: the new card. Make first commit madeInitial commitwith.gitignoreanda.txt, then New channel appeared.git initplus a.gitignoreand no commit: the new title and "Commit its files yourself", with no button.Map: ^311 (gap left by #646). Part of #615: this fixes the empty-repository wording that #615 reports. The issue's other Open folder and Clone from URL items are tracked there.
Built in Ace
No. Claude Code (fix-train worker) made this outside Ace, running against a loopback source host. It used headless Chromium to smoke the web client. Dogfooding gaps are tracked in #5.