Repository navigation
fix(host): say what's wrong with a backup or restore path, and let restore take --name - #671
Merged
Merged
Conversation
…store take --name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ace backupandace restoreprinted rawENOENT…/EEXIST…errors, and a restored channel couldn't be given its own name. They now say what's wrong:<dir> already exists. Back up into a new directory.<parent> doesn't exist. Create it first.<dir> doesn't exist.From a folder withoutbackup.json:<dir> isn't an Ace backup: it has no backup.json.The backup is incomplete: channel.sqlite is missing from <dir>.--projectfolder that doesn't exist:<dir> doesn't exist.Before, this said the folder isn't a Git repository. The same check coversace newandace import.ace restorealso takes--name <name>. The name is validated likeace new --name, and a name that's taken is refused. Without it, the copy keeps the original's name, with-1,-2, … added while that name is taken. docs/data.md now says so. It also drops the old advice to refer to the copy by ID, which became outdated once restore started renaming the copy's metadata.Smoke-tested against a loopback source host (own ACE_HOME, port 4377):
ace restore bkprintedreact-test-1.ace restore bk --project proj-plain --name over-thereprintedover-there, andace infoandace lsshow it under proj-plain.A channel named over-there already exists.--name "Bad Name!"was refused with the kebab-case rule.Map: ^845. Fixes #624: #654 fixed the lane part, and this fixes the error messages and the name.
Built in Ace
No. Claude Code (fix-train worker) made this outside Ace, running against a loopback source host. Dogfooding gaps are tracked in #5.