Repository navigation
fix(app): ask before multi-line terminal pastes and archiving running terminals; let Cmd+K open the palette - #672
Merged
Merged
Conversation
… terminals; let Cmd+K open the palette Why: apps/app/src/panels/terminal.tsx#function Terminal | without bracketed paste the shell runs each pasted line, so a multi-line paste must confirm first; Cmd/Ctrl+K is left to the window's palette, not cleared Why: apps/host/src/terminals.ts#function list | a shell counts as running a command only when its terminal's foreground group isn't the shell's own; prompt helpers that are children of the shell must not count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three terminal fixes from the map study:
clear/ Ctrl+L still clear.)terminalslisting now reports each shell's foreground command, read from the terminal's foreground process group, so idle shells and prompt helpers don't count. Archiving with only idle shells goes straight through as before.Part of #622. Left: listing and reopening shells whose tabs are gone,
ace killleaving a visible tab on "Connecting...", and the palette listing only tabs not on screen.Map: ^757, ^765, ^776 (https://ace-map.iamnbutler.pages.nexthub.sh/terminal.html#757)
Smoke: own
ace serve --loopback(isolated ACE_HOME, port 4166, SHELL=/bin/bash so there's no bracketed paste) in a headless browser. In a Terminal tab afterecho ready: Cmd+K opened the Command Palette and the screen keptready. Pastingecho one-757\necho two-757showed "Paste 2 lines?"; Paste ran both. A single-line paste showed no dialog. Withsleep 300running, the sidebar's Archive channel showed "Archive #times? … running sleep"; Cancel left it; Archive channel archived it andpgrepfound nosleep 300afterwards. Idle shells in the same channel weren't counted.Built in Ace
No. Made from Claude Code (fix-train worker), with a headless browser for the smoke, because the fix train runs outside Ace. Gap tracked in the dogfooding meta issue #5.