Repository navigation
fix(host): say when a provider rejected a saved key, not just Saved in Keychain - #673
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings → Providers kept reading "Saved in Keychain" for a key that Check had just reported as "OpenAI rejected this API key." Now Ace Helper remembers when a provider rejects a key during a Check. While the key stays the same, the row reads "Saved in Keychain, but OpenAI rejected it", and with an environment override, "OPENAI_API_KEY overrides Keychain, but OpenAI rejected it". Saving, replacing or removing the key clears the warning, and so does a Check that passes. Clients only reload settings when the verdict changes.
Smoke-tested on a loopback source host (own ACE_HOME, keychain service
ace-fixw7, port 4377, and a login shell with no provider keys) in headless Chromium:ace key set OPENAI_API_KEY, which doesn't check the key. The row read "Saved in Keychain".Map: ^53. Part of #626: this fixes the rejected-key status. Refresh already says "Read the keys again." Still open in #626:
Built in Ace
No. Claude Code (fix-train worker) made this outside Ace, running against a loopback source host. It used headless Chromium to smoke the web client. Dogfooding gaps are tracked in #5.