Repository navigation
fix(app): stop the join forms from asking for an invite link a tailnet directory can't make - #674
Merged
Merged
Conversation
…t directory can't make
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team setup's Join your team and Settings → Team → Join… no longer lead with an invite link, which only a deployed directory makes:
Follow-up to #635 (closed by #657, which left this wording); part of #603, whose directory-adoption work is left.
Map: ^118 (https://ace-map.iamnbutler.pages.nexthub.sh/team.html#118)
Smoke: own
ace serve --loopback(isolated ACE_HOME, port 4166) in a headless browser: Team setup showed the new choice text, and Join your team showed the new description with fields "Directory URL or invite link" and "Team secret, for a deployed directory".Built in Ace
No. Made from Claude Code (fix-train worker), with a headless browser for the smoke, because the fix train runs outside Ace. Gap tracked in the dogfooding meta issue #5.