[rig-sampler] Add type: "string" to all-string enum schemas

[github-actions]

Sample run: 10-triage-pr.ts

Sample executed: src/samples/10-triage-pr.ts — classifies a GitHub issue and suggests labels using s.enum for both kind and priority fields.

Run result: ✅ Succeeded in 1 turn (no repair loops). The stub produced valid output matching the schema.

Observation from the run output:

The generated <output_schema> block emitted by the harness for s.enum("bug", "feature", "question", "chore") was:

{"enum": ["bug", "feature", "question", "chore"]}

This is valid JSON Schema, but omits the type constraint. JSON Schema best-practice (and many LLM prompt guides) recommend including "type": "string" alongside enum when all values are strings — it gives the model a clearer, redundant signal to produce a string and helps schema validators surface type mismatches before value mismatches.

Change

In serializeSchema, when an EnumSchema's values are all strings, the serialized output now includes "type": "string":

{"type": "string", "enum": ["bug", "feature", "question", "chore"]}

Mixed-type or non-string enums (e.g. s.enum(1, 2, 3)) continue to emit only {"enum": [...]}.

Tests

• Updated the existing "converts enum schemas" test to expect the new type: "string" field.
• Added a new "adds type:string to all-string enums but not mixed enums" test covering string-only, number-only, mixed, and empty enum cases.

All 129 tests pass.

Generated by Daily Rig Sampler · 35.9 AIC · ⌖ 8.08 AIC · ⊞ 5.2K · ◷

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

[github-actions]

Skills-Based Review 🧠

Applied /tdd — changes are well-tested and the implementation is correct.

📋 Highlights

Positive Highlights

• ✅ New test covers all four meaningful cases: all-string, all-number, mixed, and empty enum
• ✅ Empty-enum edge case correctly skips type: "string" (via enumValues.length > 0 guard)
• ✅ Existing test updated to match new expected output — no silent drift
• ✅ Minimal, surgical change; unrelated code is untouched

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 14.4 AIC · ⌖ 3.94 AIC · ⊞ 6.3K
_{Comment /matt to run again}