Infer defineTool handler args from parameters schema#68
Merged
pelikhan merged 3 commits intoJul 23, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix OpenAPI spec validator in daily rig evaluation
Infer Jul 23, 2026
defineTool handler args from parameters schema
pelikhan
approved these changes
Jul 23, 2026
pelikhan
marked this pull request as ready for review
July 23, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily rig evaluation surfaced a recurring
defineToolusability failure: handlers that destructure args required duplicate explicit generics despiteparametersalready carrying type information. This change makesdefineToolinfer handler arg types from rigs.*schemas while preserving existing behavior for tools without parameters and plain JSON Schema configs.API typing update
defineTooloverload that mapsparametersto handler arg types viaInferSchema.defineTool("x", { handler })and explicit generic usage continue to typecheck.Regression coverage
Docs clarity
README.mdandskills/rig/SKILL.mdto document:s.*schemas