Repository navigation
feat(updater): link release notes from update dialog - #3592
Merged
Merged
Conversation
Accept the downloaded-update event, add a Release notes action when release information is present, and open the matching GitHub release page. Guard against repeat dialogs for the same version and reset the guard on update-available or update-cancelled.
setchy
marked this pull request as ready for review
November 1, 2026 21:38
A routine update check for the same pending version must not show the ready dialog again after the user chose Later. Keep the tray Restart to install entry; a different version still prompts normally.
Record the one-dialog-per-version rule, the persistent Restart to install menu entry, and the different-version/cancellation behavior.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Part of OpenSpec change
04-clean-up-dependencies-and-electron-debt(tasks 5.1–5.4).showUpdateReadyDialognow accepts the downloaded-update event and adds a Release notes action when the update carries release notes or a version.${GITHUB_BASE_URL}/${REPO_SLUG}/releases/tag/v<version>and logs a failure if the browser cannot open.Update-ready behavior
Verification
pnpm checksrc/main/updater.test.tsandsrc/main/menu.test.tspass (58 tests), including both button sets, the release URL, open failure, same-version suppression, a different version prompting again, and the cancellation reset.Notes
Based on
main.