Skip to content

feat(updater): link release notes from update dialog - #3592

Merged
setchy merged 4 commits into
mainfrom
feat/updater-release-notes
Nov 1, 2026
Merged

setchy merged 4 commits into
mainfrom
feat/updater-release-notes

Conversation

@setchy

@setchy setchy commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Part of OpenSpec change 04-clean-up-dependencies-and-electron-debt (tasks 5.1–5.4).

  • showUpdateReadyDialog now accepts the downloaded-update event and adds a Release notes action when the update carries release notes or a version.
  • Choosing Release notes opens ${GITHUB_BASE_URL}/${REPO_SLUG}/releases/tag/v<version> and logs a failure if the browser cannot open.
  • Adds a one-dialog-per-version guard.
  • Restart, Later, the notifications-disabled path, and the tray restart action remain the install paths.

Update-ready behavior

  • The dialog is shown once per downloaded version when notifications are enabled.
  • Later dismisses the dialog; the tray menu keeps Restart to install update.
  • A later check for the same downloaded version does not re-prompt. A different downloaded version prompts normally; a cancelled download clears the guard.
  • Release notes opens the matching GitHub release page. With notifications disabled, the dialog is skipped and the menu entry remains.

Verification

  • pnpm check
  • src/main/updater.test.ts and src/main/menu.test.ts pass (58 tests), including both button sets, the release URL, open failure, same-version suppression, a different version prompting again, and the cancellation reset.

Notes

Based on main.

Accept the downloaded-update event, add a Release notes action when release information is present, and open the matching GitHub release page. Guard against repeat dialogs for the same version and reset the guard on update-available or update-cancelled.
@github-actions github-actions Bot added the enhancement New feature or enhancement to existing functionality label Nov 1, 2026
@setchy
setchy marked this pull request as ready for review November 1, 2026 21:38
@setchy
setchy requested a review from afonsojramos as a code owner November 1, 2026 21:38
A routine update check for the same pending version must not show the ready dialog again after the user chose Later. Keep the tray Restart to install entry; a different version still prompts normally.
Record the one-dialog-per-version rule, the persistent Restart to install menu entry, and the different-version/cancellation behavior.
@setchy
setchy merged commit e136808 into main Nov 1, 2026
18 checks passed
@setchy
setchy deleted the feat/updater-release-notes branch November 1, 2026 21:52
@github-actions github-actions Bot added this to the Release 8.0.0 milestone Nov 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

1 participant