Repository navigation
feat: anchor to bars from other shells and keep Gitify above other windows - #27
Merged
Merged
Conversation
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
The script only anchored to
plasmashellpanels, so with other shells the popup fell back to the top-right corner. It also opened behind the focused window, because Electron cannot keep a window on top on Wayland.keepAboveon the Gitify window.Testing
npm test: 28 tests pass, including 15 new ones for full-display bars on each edge, display resizes, dock removal, docks from other shells, Plasma panel preference, andkeepAbove.keepAboveset.npm run test:live. It measures onlyplasmashellpanels and activates the tray over D-Bus without moving the pointer, so it cannot exercise the full-display bar path.