Adds git notes support via ${notes} format token - closes #2432#5085
Open
Mattwmaster58 wants to merge 1 commit intogitkraken:mainfrom
Open
Adds git notes support via ${notes} format token - closes #2432#5085Mattwmaster58 wants to merge 1 commit intogitkraken:mainfrom
Mattwmaster58 wants to merge 1 commit intogitkraken:mainfrom
Conversation
Mattwmaster58
force-pushed
the
feature/git-notes-support
branch
from
9f5fddd to
14bf396
Compare
- Adds ${notes} token to CommitFormatter for inline blame, hovers, and status bar - Adds %N to log parser commits mapping for notes from git log - Adds getCommitNotes() sub-provider method using git notes show - Adds ensureNotes() on GitCommit with @gate() and cancellation support - Adds notes to settings preview and settings HTML token documentation - Updates logParser tests for new notes field
Mattwmaster58
force-pushed
the
feature/git-notes-support
branch
from
14bf396 to
9176797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add basic support for ${notes} token in every commit token context I could think of. There was a bit of complexity because depending on where we get the commit info from, the note info can come for free (log), or requires a git invocation (blame). See: #2432
This is my first time in the codebase, a lot of this was done with AI - though I did review all the changed lines and tested everything manually myself.
Demo
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses