Skip to content

Disables no-return-await ESLint rule#5093

Merged
sergeibbb merged 1 commit intomainfrom
debt/disable-no-return-await
Apr 17, 2026
Merged

Disables no-return-await ESLint rule#5093
sergeibbb merged 1 commit intomainfrom
debt/disable-no-return-await

Conversation

@sergeibbb
Copy link
Copy Markdown
Member

@sergeibbb sergeibbb commented Apr 1, 2026

Summary

Solves contradictory rules no-return-await and @typescript-eslint/return-await:
image

image
  • Disables the no-return-await ESLint rule in the configuration
  • Removes an unnecessary comment in the runCLICommand function

Test plan

  • Verify ESLint runs cleanly with the updated config
  • Verify no regressions in CLI command execution

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 1, 2026

🤖 Augment PR Summary

Summary: Disables the core ESLint no-return-await rule to avoid incorrect warnings/contradictions when return await is needed for correctness (e.g., with using disposal semantics).
Changes: Updates eslint.config.mjs (pins @typescript-eslint/return-await) and removes/adjusts now-unnecessary per-line suppressions in affected call sites.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread eslint.config.mjs Outdated
@sergeibbb sergeibbb force-pushed the debt/disable-no-return-await branch from 89be8ee to 9626a64 Compare April 1, 2026 01:45
sergeibbb added a commit that referenced this pull request Apr 1, 2026
@sergeibbb sergeibbb force-pushed the debt/disable-no-return-await branch from 9626a64 to 77906fa Compare April 1, 2026 01:46
sergeibbb added a commit that referenced this pull request Apr 1, 2026
@sergeibbb sergeibbb force-pushed the debt/disable-no-return-await branch from 77906fa to 35cf5d1 Compare April 1, 2026 02:08
@sergeibbb sergeibbb requested a review from d13 April 1, 2026 02:12
@sergeibbb sergeibbb assigned d13 and unassigned d13 Apr 1, 2026
@sergeibbb
Copy link
Copy Markdown
Member Author

augment review

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread packages/git-cli/src/providers/patch.ts
Comment thread src/env/node/gk/cli/utils.ts
@sergeibbb sergeibbb force-pushed the debt/disable-no-return-await branch from 35cf5d1 to 6d66422 Compare April 1, 2026 02:20
@sergeibbb sergeibbb merged commit 1a9a78f into main Apr 17, 2026
6 checks passed
@sergeibbb sergeibbb deleted the debt/disable-no-return-await branch April 17, 2026 17:53
@sergeibbb sergeibbb added this to the 18.0 milestone Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants