Fix case-insensitive Git config name matching

[Byron]

Tasks

This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.

• refackiew

---

Everything below this line was generated by Codex GPT-6.

Created by Codex on behalf of Byron. Byron will review before this is ready to merge.

Fixes #2240.

GitConfigParser now matches section and option names without regard to case, so get_value("CORE", "bigname") can read [core] BigName = 1. Quoted subsection names remain case-sensitive: remote "Origin" and remote "origin" are distinct.

The existing ordered multi-dictionary indexes normalized names while retaining the first spelling for enumeration and write-back. Case variants merge into one setting with values in read order, and reads, additions, updates, removals, and renames share the same matching rules. Include sections and remote discovery also accept mixed-case section names.

Regression coverage checks duplicate values, implicit booleans, subsection case, original spelling, mutations, included files, and remote discovery. The three new regression tests failed before the fix.

Validation:

• Python 3.9.6: config suite and remote creation/removal and multiple-URL tests — 47 passed, 2 existing skips.
• Python 3.14.7: config suite — 45 passed, 2 existing skips.
• Repository-wide Ruff lint and formatting, mypy, and basedpyright passed.
• Codespell 2.4.3 and the affected write test pass after correcting the CI test value spelling.
• A scaling check parsed 1,000 and 10,000 remote sections in approximately 0.008 and 0.080 seconds.

Git behavior was checked against Git 2.50.1 and the local Git reference at 1630431f326e15fcde608827b5ff38422528eb59, particularly Documentation/config.adoc and the mixed-case/subsection tests in t/t1300-config.sh.

Commits: 94a591d4 (config matching) and c4beffeb (test value spelling).

Each commit received one codex review --commit attempt. Both attempts failed because the CLI login has expired (HTTP 401), so no Codex review result is available.

[Copilot]

🟡 Changes recommended

Unresolved moderate and critical issues remain in git/config.py.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request makes Git configuration section and option matching case-insensitive while preserving quoted subsection case sensitivity.

Changes:

• Normalizes config lookups and mutations.
• Supports mixed-case include sections and remote discovery.
• Adds regression coverage for reads, writes, includes, remotes, and booleans.

File summaries

File	Summary
test/test_config.py	Adds regression coverage.
git/remote.py	Supports mixed-case remote sections.
git/config.py	Implements normalized config-name matching.

Review details

Suppressed comments (1)

git/config.py:217

• _keymap is only populated by setall, but the constructor delegates initial entries to OrderedDict and never rebuilds the index. This matters for items_all(), which constructs _OMD(self._defaults): copied default entries can remain unindexed, so a default option spelled Foo and a section option spelled foo are treated as different keys and case-insensitive enumeration/mutation is lost. Populate the map from the entries loaded by the constructor (while preserving the existing list values).

    def __init__(self, *args: Any, **kwargs: Any) -> None:
        self._keymap: Dict[str, str] = {}
        super().__init__(*args, **kwargs)

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.