Skip to content

Allow disabling automatic terminal title - #2832

Open
savchenko wants to merge 3 commits into
gitui-org:masterfrom
savchenko:master
Open

savchenko wants to merge 3 commits into
gitui-org:masterfrom
savchenko:master

Conversation

@savchenko

@savchenko savchenko commented Jan 3, 2026 •

Copy link
Copy Markdown

Add --no-terminal-title/-n flags to disable automatic terminal title setup which was introduced in 3ede6b5

This Pull Request fixes/closes #2831.

It changes the following:

  • start_terminal() now accepts no_terminal_title
  • By default the terminal title is set, so there is no behavioural change unless requested by a user

I followed the checklist:

  • I tested the overall application
  • I added an appropriate item to the changelog
  • I added unittests
  • I ran make check without errors

Add `--no-terminal-title/-n` flags to disable automatic terminal title
setup which was introduced in 3ede6b5

Close gitui-org#2831
Add information about gitui-org#2832
@savchenko

Copy link
Copy Markdown
Author

@extrawurst , any chance this can be added to v0.28.1 ?

@extrawurst

Copy link
Copy Markdown
Collaborator

Not against it but no priority. First I want the marked ones reviewed and merged. Feel free to leave reviews please

Comment thread src/main.rs
@jesusmgg

jesusmgg commented Oct 22, 2026 •

Copy link
Copy Markdown

any chance to reconsider this one?

@savchenko
savchenko requested a review from jesusmgg October 22, 2026 01:49
@savchenko

Copy link
Copy Markdown
Author

@jesusmgg re-sync'd with master and updated changelog entry, ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make automatic terminal title optional

4 participants