Repository navigation
Conversation
libgit2 reports the "\ No newline at end of file" marker as AddEOFNL when the newline is being added and as DeleteEOFNL when it is being removed. The marker itself follows the line of the other side, though: AddEOFNL comes right after the deleted line and DeleteEOFNL right after the added one. Mapping them to Add/Delete therefore coloured the marker green below a removed line and red below an added line. The marker is not a change of its own, so map it to DiffLineType::None and render it like git does, as a plain line. Fixes gitui-org#2223 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2223.
It changes the following:
AddEOFNLwhen the newline is added andDeleteEOFNLwhen it is removed, but the marker always follows the line of the other side. gitui mapped them to Add/Delete, so the marker showed up green under the removed line (or red under the added line). It is now mapped toDiffLineType::Noneand drawn as a plain line, likegit diffdoes.asyncgit/src/sync/diff.rscovering both directions.I used Claude Code to write this change.
I followed the checklist:
make checkwithout errors