Repository navigation
Add REVIEW.md and agent permission rules - #40
Draft
steve-calvert-glean wants to merge 2 commits into
Draft
steve-calvert-glean wants to merge 2 commits into
steve-calvert-glean wants to merge 2 commits into
Conversation
REVIEW.md holds this repo's review rules for people and review agents. .claude/settings.json holds the agent permission rules in Claude Code syntax (draft-pr preset), AGENTS.md carries the same rules in prose plus the commit and PR conventions, and .codex/rules/permissions.rules compiles them for Codex. Generated with configure-agents review.
steve-calvert-glean
added
the
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reviewers and review agents have no written rules for this repo, so each review starts from generic advice. Nothing tells coding agents which actions they may take here without asking, such as commenting on PRs, merging, publishing, or pushing to
main.Change
REVIEW.md: this repo's review rules, drawn fromCLAUDE.md(zod schemas as the source of truth, the artifact seam, guarded destructive paths, narrow partials, CLI docs) and the README's rule that targets come from official docs..claude/settings.json: agent permission rules in Claude Code syntax, using thedraft-prpreset. Agents may push feature branches and open draft PRs. They ask before comments, reviews, merges, releases, publishing, force pushes and pushes tomain.AGENTS.md: the same rules in plain language ("Ask first", "Never"), a pointer toREVIEW.md, and the commit and PR conventions. The conventions come from the repo's merge settings, release tooling and recent history. This repo kept its agent guide inCLAUDE.md, soAGENTS.mdis new andCLAUDE.mdimports it with@AGENTS.md..codex/rules/permissions.rules: the same rules compiled for Codex, which loads them in trusted projects.configure-agents reviewgenerated the rules files (gleanwork/configure-agents#1).configure-agents check --review-onlypasses.Effect on contributors
Claude Code and Codex now ask before an agent runs a gated command in this repo, such as
gh pr comment,gh pr review,gh releaseornpm publish. This applies to every contributor's agent sessions here. Nothing changes for commands people run themselves. No CI workflow runs an agent, so CI is unaffected..claude/is git-ignored on some machines, so.claude/settings.jsonwas added withgit add -f.CI
The production dependency audit fails on a
sprintf-jsadvisory (viagray-matterandargparse) that was published aftermainlast passed. It is unrelated to this change. #39 bumps the dependency and passes the same audit, so this PR passes once #39 merges.