Repository navigation
Test infrastructure (1 of 2) - #182
Merged
Merged
Conversation
…ipts - Guard sake.initConfig() behind a SAKE_TEST_MODE env var, since importing lib/sake.js otherwise calls initConfig() at module load time and exits the process outside a real plugin directory - Add a minimal fixture plugin directory and a chdir helper so tests can exercise sake's config logic against a realistic plugin - Add npm test and test:watch scripts, and a throwaway import-crash smoke check across every tasks/*.js file to prove the gate works
Runs on ubuntu-latest with actions SHA-pinned to node24-native releases (checkout v7.0.1, setup-node v7.0.0), resolving the Node version from package.json's existing engines field rather than hardcoding one.
ajaynes-godaddy
changed the title
ajaynes-godaddy
added a commit
that referenced
this pull request
Oct 4, 2026
ajaynes-godaddy
added a commit
that referenced
this pull request
Oct 4, 2026
Covers the logic introduced for MWC-1505: isNonInteractive()/isDryRunDeploy()/ newPluginVersion() in helpers/arguments.js, the --skip-linting gating in compile(), the --dry-run/--non-interactive gating in deployTask(), the --new-version fallback in replaceVersionTask(), and the non-interactive short-circuits in promptDeployTask/promptWcUploadTask/promptTestedReleaseZipTask. Builds on the test infrastructure merged in from PR #182 rather than reinventing it; does not re-cover the pre-existing functions/behavior already tested by PR #181.
7 tasks
ajaynes-godaddy
changed the title
nikolas4175-godaddy
previously approved these changes
Oct 5, 2026
nikolas4175-godaddy
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the test infrastructure needed to run a
node:test-based test suite againstsake: aSAKE_TEST_MODEgate solib/sake.jscan be imported outside a real plugin directory, a minimal fixture plugin directory,npm test/test:watchscripts, and a GitHub Actions workflow to run the suite on every push and pull request.Details
No new dependencies were added — the gate, fixture, and workflow are scaffolding only. The actual test coverage built on top of this infrastructure is split out into a separate PR (#181), now rebased on top of this branch.
QA
npm testpasses locallyBefore merge